Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.require() with expose: true use backslashes on Windows #1358

Closed
piranna opened this issue Aug 18, 2015 · 5 comments
Closed

.require() with expose: true use backslashes on Windows #1358

piranna opened this issue Aug 18, 2015 · 5 comments

Comments

@piranna
Copy link

piranna commented Aug 18, 2015

When using .require() method on Windows with the expose:true flag, the IDs are being generated with backslashes, like /apps\\Call instead of /apps/Call, so later they can't be found when require()ing them because they are not found. I think this is somewhat related to https://github.com/substack/node-browserify/pull/503/files and https://github.com/substack/node-browserify/pull/1096/files and probably the fix would be the same, just replace the backslashes previously to set the path at the browserify output.

@piranna
Copy link
Author

piranna commented Aug 18, 2015

Probably it would be also a good idea to sanitice this way all the paths to be sure they are only using slashes and not backslashes...

@piranna
Copy link
Author

piranna commented Aug 19, 2015

Taking a look on the code, I suspect the problem is at this path.resolve(). I don't have a Windows machine here to try it, though :-(

@julian-maughan
Copy link
Contributor

This issue is currently preventing me upgrading from a fairly old version of Browserify, so I'd be great to see it resolved. Hope the PR helps.

@ghost
Copy link

ghost commented Jan 8, 2016

Should be fixed in 12.0.2.

@ghost ghost closed this as completed Jan 8, 2016
@githubVivek55
Copy link

this issue is still exist in windows for external dependencies section. Could anyone please help me how to resolve that..

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants