Browserify tolerates require() of invalid JSON

[s100]

This is browserify@13.0.1 and Node.js v6.2.2.

file.json:

{
  key: "value"
}

index.js:

require("./file.json");

Command line:

browserify index.js

Expected output: some kind of error because of the invalid JSON?

Actual output:

(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
module.exports={
  key: "value"
}

},{}],2:[function(require,module,exports){
require("./file.json");
},{"./file.json":1}]},{},[2]);

[jmm]

Hello @s100, thanks for the report! I agree, that is uncool. We could solve this by trying to parse as JSON at bundling time in the json phase of the pipeline, or defer it to runtime, or if necessary provide an option to toggle. Would you be interested in working on a failing test and / or PR for this?

[s100]

Unfortunately I don't know the first thing about Browserify's internals, I am just a humble user.

[jmm]

Ok, no problem, just wanted to give you the first crack at it 😃