Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up code so NPM audit doesn't trigger alerts & clean up tests that used deprecated Buffer calls #1900

Open
infintesimal opened this issue Mar 1, 2019 · 1 comment

Comments

@infintesimal
Copy link

infintesimal commented Mar 1, 2019

Version 16.2.3 of browserify reports 15 vulnerabilities, 14 moderate and 1 high.
I have traced all of these back to two devDependencies and 3 of the unit tests.
The dev dependencies are concat-stream and tap; they just require upversioning.
The unit tests required small modification to make safe calls to Buffer in the Buffer.from() style.

I am opening a corresponding pull request #1899

To replicate:
clone down repo and checkout 16.2.3 or master
npm i install --package-lock-only

Try out my pull request to get to zero vulnerabilities and all tests passing with 1 test skipped (evil json test which only runs in windows environment, which I don't have access to).

@ljharb
Copy link
Member

ljharb commented Mar 1, 2019

vulns in dev deps rarely matter, nor in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants