Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License incompatibility, GPLv2 nested dependency #488

Closed
mbrevoort opened this issue Sep 20, 2013 · 8 comments
Closed

License incompatibility, GPLv2 nested dependency #488

mbrevoort opened this issue Sep 20, 2013 · 8 comments

Comments

@mbrevoort
Copy link

This license incompatibility exists for any commercial/private use of browserify:

browserify (MIT)
--> browser-builtins (MIT)
--> buffer-browserify (MIT/X11)
--> base64-js (GPLv2)

We need to remove @beatgammit 's dependency from buffer-browserify unless he's willing to change the license. I'll open an issue in buffer-browserify as well.

@danielchatfield
Copy link

I hate GPL

@mbrevoort
Copy link
Author

seems like there's only a single line where this is used
https://github.com/toots/buffer-browserify/blob/master/index.js#L131

looking for alternatives now....

@mbrevoort
Copy link
Author

As it turns out, the package.json of base64-js points to the wrong Github repo, it points to https://github.com/beatgammit/deflate-js (https://github.com/beatgammit/base64-js/blob/master/package.json#L8) which is GPLv2 licensed.

The correct repo looks like https://github.com/beatgammit/base64-js that doesn't specify a license at all, but most of @beatgammit 's other repos are also GPLv2 licensed as well so I wouldn't be surprised if he would explicitly GPLv2 base64-js as well. Either way we need to remove the ambiguity.

@toots
Copy link
Contributor

toots commented Sep 20, 2013

It shouldn't be too hard to rewrite base64-js or even compile it with emscripten ^^

@toots
Copy link
Contributor

toots commented Sep 20, 2013

@beatgammit
Copy link

My bad, it's MIT licensed. I'll make the change now (embarassing error in the package.json).

The deflate-js package is GPL for now, but that's because of external dependencies. My code in that repo is MIT, but the dependencies make it GPL. GPL does suck...

@beatgammit
Copy link

Change done. If I don't have a license in another one of my projects, just ask me. Most likely it's MIT or BSD licensed. The only differences are usually things that have GPL dependencies.

@mbrevoort
Copy link
Author

@beatgammit (for the 3rd time) thanks!! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants