Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when using insertGlobals #648

Closed
fixe opened this issue Feb 12, 2014 · 7 comments
Closed

Issue when using insertGlobals #648

fixe opened this issue Feb 12, 2014 · 7 comments

Comments

@fixe
Copy link

fixe commented Feb 12, 2014

When using insertGlobals I'm getting the following error in _prelude.js:

Cannot find module node_modules/process/browser.js

The file is being included in bundled file but Browserify cannot detect it. Is there anything I can include to make debugging easier?

@grassick
Copy link

This is caused by: #634

The word process is the problem.

@fixe
Copy link
Author

fixe commented Feb 12, 2014

Ok, thank you.

@shuhei
Copy link

shuhei commented Feb 15, 2014

@fixe Is this issue solved for you?

Files that have certain kinds of RegExp, like /"/, still don't work with insertGlobals option. For example, we have a trouble with d3. Waiting for this pull request to be merged.

@fixe
Copy link
Author

fixe commented Feb 15, 2014

No, still not working. Using browserify 3.30.0.

@hendrikcech
Copy link

I'm having the same problem, even when not explicitly using insertGlobals. Have you found a workaround?

@shuhei
Copy link

shuhei commented Feb 17, 2014

As a workaround, browsery 3.24.8 would work.

3.24.9 and newer use mine for dependency detection but it overlooks dependencies on certain kinds of source code. insertGlobals: false removes unnecessary dependencies but it just reduces the risk a bit.

On Feb 17, 2014, at 11:27 AM, Hendrik Cech notifications@github.com wrote:

I'm having the same problem, even when not explicitly using insertGlobals. Have you found a workaround?


Reply to this email directly or view it on GitHub.

@hendrikcech
Copy link

This PR fixes the issue for me: creationix/mine#6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants