Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streams are very broken #963

Closed
feross opened this issue Oct 25, 2014 · 3 comments
Closed

Streams are very broken #963

feross opened this issue Oct 25, 2014 · 3 comments

Comments

@feross
Copy link
Member

feross commented Oct 25, 2014

This very simple code throws an exception in the latest browserify.

var concat = require('concat-stream')
var stream = require('stream')
var s = new stream.PassThrough()
Uncaught TypeError: undefined is not a function _stream_duplex.js:71
  Duplex _stream_duplex.js:71
  Transform _stream_transform.js:118
  PassThrough _stream_passthrough.js:41
  /Users/feross/code/test.js.concat-stream test.js:3
  s _prelude.js:1
  e _prelude.js:1
  (anonymous function) _prelude.js:1

Something is very broken, but I haven't been able to figure out what's causing it yet. I've been pulling my hair out. Can someone please take a look?

@feross
Copy link
Member Author

feross commented Oct 25, 2014

Looks to be related to this issue: nodejs/readable-stream#95

@feross
Copy link
Member Author

feross commented Oct 25, 2014

Two PRs out to fix this issue:

@ghost
Copy link

ghost commented Oct 25, 2014

Merged in 6.1.1. Thanks for the patch!

@ghost ghost closed this as completed Oct 25, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant