Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of puppeteer is breaking the build 🚨 #74

Closed
greenkeeper bot opened this issue Oct 4, 2018 · 2 comments
Closed

An in-range update of puppeteer is breaking the build 🚨 #74

greenkeeper bot opened this issue Oct 4, 2018 · 2 comments

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Oct 4, 2018

The dependency puppeteer was updated from 1.8.0 to 1.9.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

puppeteer is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v1.9.0

Big Changes

API Changes

Added:

Bug Fixes

  • #2374 - feat(browser): Run puppeteer in browser (POC)
  • #2377 - Certificates error using puppeteer
  • #2721 - page.goto doesn't clear internal timeout when the browser is closed
  • #2888 - Cannot read property '_bodyLoadedPromiseFulfill' of null
  • #2918 - Support waitForNavigation for frames
  • #3104 - Full page screenshot fails when defaultViewport is null
  • #3109 - Is it clear what <...Type> means in the docs?
  • #3204 - docs: mention require('puppeteer-core')
  • #3221 - As for puppeteer to emulate the movement of the mouse while pressing?
  • #3232 - Add documentation and examples for iframe API.
  • #3234 - Black render with omitBackground: true
  • #3340 - Does --filter=SomeTest do anything when running npm run unit

Raw Notes

4abf7d1 - docs(bundling): add docs about bundling for web (#3348)
8becb31 - test: add failing test for page.select (#3346)
5ebfe1a - docs(contributing): remove the --filter note (#3342)
cd54ce3 - fix(types): upgrade node types to 8.10.34 (#3341)
c9657f8 - docs(api.md): minor grammar and consistency fixes (#3320)
c237947 - chore(types): upgrade to TypeScript 3.1.1 (#3331)
842fee8 - fix(page): full page screenshot when defaultViewport is null (#3306)
e75e36b - feat(chromium): roll Chromium to r594312 (#3310)
85aca8e - chore(testserver): prepare test server (#3294)
9c89090 - chore(testrunner): fix readme description (#3293)
12e317c - chore: add .npmignore for testrunner (#3290)
5b3ddf5 - chore(testrunner): bump version to v0.5.0-post (#3291)
907d9be - chore: prepare testrunner to be published to npm (#3289)
4e48dfc - feat(launcher): add experimental "transport" option to pptr.connect (#3265)
5acf953 - feat(frame): introduce Frame.goto and Frame.waitForNavigation (#3276)
ad49f79 - docs(api.md): Fix description of SecurityDetails class (#3277)
0b9d8a6 - feat: async stacks for all "async" public methods (#3262)
9223bca - refactor: move navigation management to FrameManager (#3266)
27477a1 - docs(api.md): Fix typo (#3273)
b97bddf - refactor: unify response tracking in page.goto and waitForNavigation (#3258)
a1a211d - chore: nicer stack highlight (#3259)
a4abb4a - feat(chromium): Roll Chromium to r591618 (#3263)
7f00860 - fix(browserfetcher): Fix windows fetching (#3256)
f5d388a - docs(api.md): add example for Mouse class (#3244)
d547b9d - fix(browser): browser closing/disconnecting should abort navigations (#3245)
f0beabd - chore: drop DEBUG for public API calls (#3246)
d929f7e - fix: set JPG background to white when omitBackground option is used (#3240)
6ec3ce6 - chore: make sure Puppeteer bundling works (#3239)
f49687f - docs(api.md): add frame example (#3237)
a582acd - feat(chromium): roll Chromium to r590951 (#3236)
7ec0801 - fix: expect Network.responseReceived event is never dispatched (#3233)
c644a3b - test: make sure zero-width screenshots don't hang (#3214)
9c4b6d0 - refactor: use browser-compliant interface of 'ws' (#3218)
56b3bd8 - docs(readme.md): Added yarn guide also to puppeteer-core (#3227)
6581ee9 - docs: add ndb as a debugging tip (#3195)
1b2c811 - refactor: move Connection to use ConnectionTransport (#3217)
c967aeb - docs(api.md): add an include statement for puppeteer-core (#3213)
c5511ec - docs(api.md): Clarify how to call page.setCookie (#3215)
78e9d5c - chore: bump version to v1.8.0-post (#3212)

Commits

The new version differs by 40 commits.

  • f6c05e6 chore: mark version v1.9.0 (#3350)
  • 4abf7d1 docs(bundling): add docs about bundling for web (#3348)
  • 8becb31 test: add failing test for page.select (#3346)
  • 5ebfe1a docs(contributing): remove the --filter note (#3342)
  • cd54ce3 fix(types): upgrade node types to 8.10.34 (#3341)
  • c9657f8 docs(api.md): minor grammar and consistency fixes (#3320)
  • c237947 chore(types): upgrade to TypeScript 3.1.1 (#3331)
  • 842fee8 fix(page): full page screenshot when defaultViewport is null (#3306)
  • e75e36b feat(chromium): roll Chromium to r594312 (#3310)
  • 85aca8e chore(testserver): prepare test server (#3294)
  • 9c89090 chore(testrunner): fix readme description (#3293)
  • 12e317c chore: add .npmignore for testrunner (#3290)
  • 5b3ddf5 chore(testrunner): bump version to v0.5.0-post (#3291)
  • 907d9be chore: prepare testrunner to be published to npm (#3289)
  • 4e48dfc feat(launcher): add experimental "transport" option to pptr.connect (#3265)

There are 40 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Oct 4, 2018

After pinning to 1.8.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

@joelgriffith
Copy link
Collaborator

Addressed in new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant