Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to prefix 3rd-party includes indicating source library #60

Open
jerinphilip opened this issue Mar 21, 2021 · 0 comments
Open
Labels
cleanup Something that can be refactored or better organized

Comments

@jerinphilip
Copy link
Contributor

There's a translator folder in bergamot-translator and also 3rd-party/marian-dev. When files are included, it's not obvious which folder the sources came from, and leaving it thus can potentially lead to issues. For example, below file which includes translator from both marian and bergamot-translator with no way to distinguish on first look.

#include "translator/output_collector.h"
#include "translator/output_printer.h"
#include "translator/parser.h"
#include "translator/response.h"
#include "translator/service.h"

While this file is not strictly necessary here, this should ideally be configured so that the source-library is known, in this case 'marian' or 'bergamot-translator'. Unsure of the solution, but filing an issue.

@jerinphilip jerinphilip added the cleanup Something that can be refactored or better organized label Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Something that can be refactored or better organized
Projects
None yet
Development

No branches or pull requests

1 participant