Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update marian-dev submodule to use its master branch #70

Closed
abhi-agg opened this issue Mar 24, 2021 · 2 comments · Fixed by #73
Closed

Update marian-dev submodule to use its master branch #70

abhi-agg opened this issue Mar 24, 2021 · 2 comments · Fixed by #73
Assignees

Comments

@abhi-agg
Copy link
Contributor

abhi-agg commented Mar 24, 2021

Currently, the marian-dev submodule of this repository links to wasm branch of marian-dev

Change it back to master branch.

@jerinphilip
Copy link
Contributor

Are you on this @abhi-agg? I can couple this a workflow file rearrangement now that are no master / wasm differences.

@jerinphilip jerinphilip self-assigned this Mar 25, 2021
@abhi-agg
Copy link
Contributor Author

abhi-agg commented Mar 25, 2021

I can do this but @XapaJIaMnu 's PR should be merged to browsermt/marian-dev master before we make this switch. Otherwise, things will not work.

@XapaJIaMnu Could you please merge your change to browsermt/marian-dev's master? We can start this task as soon as you merge it.

Doing this will also make this PR simpler because @qianqianzhu will not have to make a marian-dev submodule change there. She shouldn't be dealing with the failures pertaining to this change in her PR (which currently is happening) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants