Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Contributing to Abricotine #310

Closed
Tokelin opened this issue Nov 19, 2021 · 7 comments
Closed

Contributing to Abricotine #310

Tokelin opened this issue Nov 19, 2021 · 7 comments
Labels

Comments

@Tokelin
Copy link

Tokelin commented Nov 19, 2021

Hello,

I've been using this great editor for a few months now (even to draft this) and I can only say good things about it. Recently I've been interested with doing some open source contributions and since it's an Electron app I feel it's something that should be easy for me to do. However I noticed this comment of yours on one of the PRs - #293 (comment). I would love to contribute to this project, but - ultimately - I just want to be reassured that I won't be left to endlessly open PRs with no chance of merging. Currently I'm in the process of getting the code running locally (Windows and node-gyp are... less than cooperative to put it nicely 😁) with the intent to poke around and see where I can improve, enhance or fix something. Of course I am open to feedback in the sense of issue priority and such.

Thank you for your time and this amazing project.

@brrd
Copy link
Owner

brrd commented Nov 19, 2021

TL;DR: Abricotine is going to be discontinued. Please don't waste your time fixing it.

Thanks you for your interest in Abricotine.

As you noticed, I'm today involved in other projects and I lack time and motivation to keep on maintaining this application. Moreover I must confess that I personally switched to another markdown editor, which makes the project even less appealing to me.

For months (years?) I'm doing my best to provide a minimum support and maintenance because I know Abricotine still have some enthusiastic users and contributors, and feel kind of guilty to give them up 😓

(By the way, I thank them very much for their support 🙏)

But to be honest I'm thinking of dropping this project soon. And even if I could find the motivation to keep on working on it, I would probably rewrite most of the code (which appears to be 50% garbage from my today point of view). Anyway, I definitely don't want to spend my time reviewing changes in the current code. I'm sorry.

Of course you can decide to create and maintain your own fork. But before you spend more of your time on it, you need to know that most of the app was written six years ago, when I was a total JavaScript beginner. At this time it was supposed to be nothing more than a training project. I could not find any markdown editor featuring inline preview, so I decided to create mine and publish it as an open-source software.

Things changed a lot since then. I personally learned how to be a better developer (or at least I hope so). The JavaScript ecosystem moved to frameworks, Typescript and ES6. Electron and NodeJs improved a lot. Github released Github Actions. Marijn Haverbeke (the creator of CodeMirror) developed the ProseMirror framework and some very interesting derived editors appeared. Etc.

And the most important, plenty of very good alternatives to Abricotine came to the market:

So my advice would be either to contribute to one of those projects instead (at least two of them use Electron) or to write your own editor if you don't like them. But I don't really like the idea that developers will waste their precious time fixing my old dirty code...

I'm sorry for this answer which is probably not the one your wanted to read.

By the way, I'm taking the freedom to pin this issue to increase its visibility.

@brrd brrd added the question label Nov 19, 2021
@brrd brrd pinned this issue Nov 19, 2021
@Tokelin
Copy link
Author

Tokelin commented Nov 19, 2021

Thank you for your openness and the recommendations for other Markdown editors. I cannot lie and say I'm not disappointed by the response, but I can completely understand it.

I wish you all the best in your future endeavours!

@SudoVanilla
Copy link

Hmm...I would love to continue this project. Anything we can do?

@2brownc
Copy link

2brownc commented Mar 6, 2022

I mainly use Abricotine because of it's "copy as HTML" feature. Do know any markdown editors that have this feature?

@SudoVanilla
Copy link

I also wanted something like that for website building, but Jekyll exist

@granbosque
Copy link

I don't like you calling it old dirty code... 😅
I have not found any other editor that reunites all of these features:

  • i18n (not in marktext)
  • inline display of images (not in ghostwriter)
  • Themeable and editing directly in markdown, without need to switch between edit and preview mode.
  • Good interface

It lacks some features, but I think it's one of the most usable editor... also thinking in contributing or forking.

@brrd
Copy link
Owner

brrd commented Jul 19, 2023

Abricotine is discontinued. See #347.

@brrd brrd closed this as completed Jul 19, 2023
@brrd brrd unpinned this issue Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants