Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide tests for Rust 1.4 #2

Closed
matklad opened this issue Oct 29, 2015 · 7 comments
Closed

Provide tests for Rust 1.4 #2

matklad opened this issue Oct 29, 2015 · 7 comments

Comments

@matklad
Copy link

matklad commented Oct 29, 2015

There is at least one language change that is currently not covered by tests: rust-lang/rust#27451

FYI: we are using ctrs in tests in https://github.com/alexeykudinkin/intellij-rust and it helps us a lot :)

@brson
Copy link
Owner

brson commented Oct 29, 2015

Wow! I'm glad you are using it. Maybe this will inspire me to whip it into shape.

@matklad
Copy link
Author

matklad commented Oct 29, 2015

Let me provide you with our experience with ctrs then :)

We use it to "verify" our parser. That is, we check that every file parses somehow.

We do not verify that the parse tree is right, because we don't have a correct answer to compare with. In general I don't think it is feasible to compare concrete parse trees, because they will be different in details.

It might be possible to compare lexical structure though. @winger even wrote a comparison tool: winger/intellij-rust@62e5d81. We don't use it now because of the difficulties of maintaining rust subproject within Java/Kotlin codebase.

@brson
Copy link
Owner

brson commented Oct 31, 2015

@matklad I'm in the process of rewriting the python test driver as a cargo project (it will use build scripts to generate rust #[test] cases that call to rustc to run the tests). I know you aren't using the provided test driver now, but will this be more or less convenient for you?

@matklad
Copy link
Author

matklad commented Oct 31, 2015

I don't know :) It should not matter much, because from Java point of view it will be just different external processes.

Rust might be sightly easier to distribute: if you are messing with ctrs then most likely you have cargo installed, but, if you are using Windows, Python may be absent.

@brson
Copy link
Owner

brson commented Nov 4, 2015

Updated for 1.4.

@brson brson closed this as completed Nov 4, 2015
@matklad
Copy link
Author

matklad commented Jul 22, 2016

FYI: we've drop ctrs from IntelliJ Rust test suite and test our parser on the compiler and standard library sources instead.

The main reason is that we must support nightly features, because the standard library uses them.

@brson
Copy link
Owner

brson commented Jul 22, 2016

@matklad Thanks for the update. Sorry I haven't maintained this thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants