Add support for the SDL mixer. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heya @pcwalton |
|
@AngryLawyer Good catch, updated the commit. |
This is the only way to get audio support in Rust at the moment; the low-level SDL_audio stuff wants to run a callback on a separate thread and that will segfault at the moment. brson's stuff should eventually fix this, but for now the SDL mixer must be used.
|
And added |
|
Merged in and compiles! Thanks for your efforts, @pcwalton. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only way to get audio support in Rust at the moment; the
low-level SDL_audio stuff wants to run a callback on a separate thread and that
will segfault at the moment. brson's stuff should eventually fix this, but for
now the SDL mixer must be used.