Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskClient should run TaskScheduler in its own thread. #30

Closed
brthor opened this issue Jun 3, 2019 · 0 comments · Fixed by #33
Closed

TaskClient should run TaskScheduler in its own thread. #30

brthor opened this issue Jun 3, 2019 · 0 comments · Fixed by #33

Comments

@brthor
Copy link
Owner

brthor commented Jun 3, 2019

In its current implementation, the TaskClient runs the TaskScheduler in the same loop it uses to execute tasks.

Tasks of any duration more than a second will cause the TaskScheduler to start running behind, scheduled tasks to be moved to the execution queue late, and recurring tasks to be potentially missed.

As a part of fixing this issue, tests should be developed which deliberately use long-running tasks and prove that scheduled tasks are not moved to the execution queue late, and recurring tasks are not missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant