Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a bug when import codes from original repo to another #16

Closed
xialonglee opened this issue Jan 12, 2017 · 0 comments
Closed

a bug when import codes from original repo to another #16

xialonglee opened this issue Jan 12, 2017 · 0 comments

Comments

@xialonglee
Copy link

xialonglee commented Jan 12, 2017

there is a bug waiting for fixed

if a man import some codes from one repository to another, like this pr:
kubernetes/community /pull/118 ( i don't want make a link points to that pr , it will notice the participants in that pr )
the pr imported some docs form repo kubernetes/kubernetes to repo kubernetes/community with commit logs
so a person who commit in repo kubernetes/kubernetes now will have a copy in kubernetes/community too(but different SHA, i.e. you have tow commits are totally same but different SHA in two repos). in this case , the author and the committer of these two commits are same, so here comes the problem.
the scheme that we find a pr form a commit is that :

  1. seaching a pr from commit's SHA with repos and author name specified , if not found , it may be the case that the committer and the author are not the same, go step 2
  2. seaching a pr from commit's SHA, but now change author name to committer .
    but according this scheme can not pr in the situation i mention above, so i think we should add a step 3 that do not specified the author arg

i also doubt whether it is reduntant that specified author arg when searching pr. may be specified repos arg is enough. if returns many, we could filter them by author's name.

@bruceauyeung

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant