Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate commands for opening and closing the console from the Plugin menu #274

Open
Keyhabit opened this issue Jan 11, 2023 · 5 comments
Open
Labels

Comments

@Keyhabit
Copy link

Keyhabit commented Jan 11, 2023

This would be more useful to me than the current 'toggle' command as it requires me to check whether the console is already open when automating things with another scripting language. Also, when I set up a keyboard shortcut for the current "Show Console" menu command, the command only works when the main editing window has focus. It is not possible to use it to close the console window or its command line when either of those has focus. It would be great if that could be implemented somehow. Thanks!

@chcg chcg added the Feature label Jan 11, 2023
@chcg
Copy link
Collaborator

chcg commented Jan 11, 2023

These are two requests from my understanding:

  • key shortcut is not functional if the console window has focus. I think that needs to be checked and if possible be fixed.
  • toggling seems to be a feature that makes sense for most of the users and splitting it up into two menu commands has no benefit for the normal user. Also many of other plugins work this way. So I would consider that change less likely to be implemented if there are not more supporters for this change or better reasons to convince me.

@alankilborn
Copy link

key shortcut is not functional if the console window has focus. I think that needs to be checked and if possible be fixed

Wouldn't the plugin have to process keys itself then, and if so, does the plugin have access to what keycombo the user has assigned?

toggling seems to be a feature that makes sense

Toggle makes some sense. How about a way for code to know if the console is currently shown or hidden, though? console.isHidden() or some such?

@Keyhabit
Copy link
Author

Thanks for considering my two requests.

The shortcut fix indeed seems to depend on whether plugin controls can register / define shortcuts.

User can use Alt-p and navigate through the plugin menu to the command regardless of what control has focus, but a direct shortcut that works everywhere would be much more comfortable.

Can't check just now, but if open and close console commands could be made available in NPP's shortcut configuration without appearing on and cluttering up the plugin menu, that would be very welcome.

@Yaron10
Copy link

Yaron10 commented Jan 11, 2023

@chcg,

toggling seems to be a feature that makes sense for most of the users and splitting it up into two menu commands has no benefit for the normal user. Also many of other plugins work this way.

👍

BTW, are you planing to update PS v2 to the latest Scintilla and Lexilla?

Thank you.

@alankilborn
Copy link

How about a way for code to know if the console is currently shown or hidden, though? console.isHidden() or some such?

Another user desires this, see N++ Community site HERE, and refer the Apr 9, 2023, 3:39 AM posting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants