Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background Color of Bash Indicator #26

Closed
Phidelux opened this issue Mar 24, 2016 · 13 comments
Closed

Background Color of Bash Indicator #26

Phidelux opened this issue Mar 24, 2016 · 13 comments
Labels

Comments

@Phidelux
Copy link
Contributor

The Background Color of the bash indicator (second line) is not transparent but black.

@brujoand
Copy link
Owner

Interesting. Could you provide the exact output of echoing $PS1?

@brujoand brujoand added the bug label Mar 24, 2016
@Phidelux
Copy link
Contributor Author

Here you go:

\n\[\]\[\] awilhelm \[\]\[\]\[\]\[\] ~ \[\]\[\]\[\] \[\]\[\]\[\]\[\] 12:28 \[\e[00m\]\n\[\]\[\] ➜ \[\e[00m\]

@brujoand
Copy link
Owner

brujoand commented Apr 1, 2016

I'm not sure what's causing this. My initial thought was that there was something wrong with color generation. But I think that's in the clear. Since my PS1 looks exactly like yours, I'm starting to wonder if this might be related to byte length vs char length. Is your LANG variable set to some variant of UTF-8?

@dflock
Copy link
Contributor

dflock commented Apr 2, 2016

echo $LANG

en_CA.UTF-8

echo $PS1

\n\[\]\[\] duncan \[\]\[\]\[\]\[\]\[\]\[\] ~ \[\]\[\]\[\]\[\] bin \[\]\[\]\[\]\[\] sbp \[\]\[\]\[\]\[\] master u= \[\]\[\]\[\]\[\] \[\]\[\]\[\]\[\] last: 0m 0s \[\]\[\]\[\]\[\] 00:49:08 \[\e[00m\]\n\[\]\[\] ➜ \[\e[00m\]

Looks fine, though:

image

@Phidelux
Copy link
Contributor Author

Phidelux commented Apr 4, 2016

Having this issue on both laptops and my desktop. All using en_US.UTF-8 in $LANG.

@brujoand
Copy link
Owner

brujoand commented Apr 5, 2016

I'm at at a loss to reproduce this. Would you mind posting a full width screenshot of your prompt @Phidelux ? And is this bug irrelevant to which path / plugins are active?

@ghost
Copy link

ghost commented Jun 14, 2016

@brujoand
Copy link
Owner

Is this still an issue after the latest merge? Iirc the way this is handled now is to reset all colors, then set the foreground.

@ghost
Copy link

ghost commented Jun 14, 2016

Yes, it was still an issue, I had black backgrounds behind the arrows, and the prompt_ready arrow had a black background. The suggestion in the link fixed the issue.

@ffjia
Copy link

ffjia commented Jul 20, 2016

If I remember correctly, there's no such problem, at least several months ago. I encountered same issue after running git pull, so it could be introduced by new pull request?

@brujoand
Copy link
Owner

Sorry I forgot about this one. It is resolved now on iTerm/osx. Anyone on linux who could confirm?

@dflock
Copy link
Contributor

dflock commented Apr 2, 2018

Looks fine to me on linux - but then it always has.

@brujoand
Copy link
Owner

brujoand commented Apr 4, 2018

Cool thanks. I think this bug is only revealed if the user applies some color theme to the terminal. Closing until proven wrong then 👍

@brujoand brujoand closed this as completed Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants