Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with parallelTransition (in rare ocasions it finished witho… #23

Merged
merged 1 commit into from Jun 15, 2015

Conversation

jperedadnr
Copy link
Contributor

…ut being executed none of the children transitions, and tiles in board were missplaced)

Fixed bug with layout overlay requested when it was already shown.

…ut being executed none of the children transitions, and tiles in board were missplaced)

Fixed bug with layout overlay requested when it was already shown.
brunoborges added a commit that referenced this pull request Jun 15, 2015
Fixed bug with parallelTransition (in rare ocasions it finished witho…
@brunoborges brunoborges merged commit 1796b0e into brunoborges:master Jun 15, 2015
@brunoborges
Copy link
Owner

Thanks @jperedadnr :-)

@jperedadnr
Copy link
Contributor Author

I'm not sure if you will have the time to have a look at why parallelTransition as global field missed to execute some transitions in rare occasions.

The parallel transition was created only once, and on every move we added some transitions, play it, wait for it to finish, and then clear the transitions and start all over again.

I've pushed it to the limit with AI algorithms and very short transitions (about 10 ms), and at some point I noticed that from time to time the parallel transition entered the finished handler, but none of its transitions were executed! This happened with more frequency on shorter transitions.

So by declaring a local parallel transition, I force to create a new one on every move, and now it doen't fail anymore...

@brunoborges
Copy link
Owner

But does it decrease overall performance? I wonder if this would look bad on a Raspberry Pi, for example

@jperedadnr
Copy link
Contributor Author

I don't think so! Note that we already create on every move several SequenceTransitions and Timelines.

@brunoborges
Copy link
Owner

Alright!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants