Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Url Transformer #4

Open
brunodles opened this issue Aug 5, 2018 · 2 comments
Open

Create Url Transformer #4

brunodles opened this issue Aug 5, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@brunodles
Copy link
Owner

Some pages uses / or // in their urls, this means that the browser will interpret it as host an protocol.

Provide a way to prepend it with host or protocol

@Selector("a")
@AttrCollector("href")
@UrlFixer
String fixedUrl();

Here you can find an example:
https://play.google.com/store/search?q=alto&c=apps

link

<a class="card-click-target" href="/store/apps/details?id=com.noodlecake.altosadventure" aria-label="     Alto's Adventure    ">  <span class="movies preordered-overlay-container id-preordered-overlay-container" style="display:none"> <span class="preordered-label">Encomendados</span> </span> <span class="preview-overlay-container" data-docid="com.noodlecake.altosadventure">  </span>  </a>

image

<img alt="Alto's Adventure" class="cover-image" data-cover-large="//lh3.googleusercontent.com/gxylrEt14mAOWhHLJbuHg7lIa3h8t5tLbXcCZL_ox437C4UVO7Euk9rj6fjGLUdnTWw=w340-rw" data-cover-small="//lh3.googleusercontent.com/gxylrEt14mAOWhHLJbuHg7lIa3h8t5tLbXcCZL_ox437C4UVO7Euk9rj6fjGLUdnTWw=w170-rw" src="//lh3.googleusercontent.com/gxylrEt14mAOWhHLJbuHg7lIa3h8t5tLbXcCZL_ox437C4UVO7Euk9rj6fjGLUdnTWw=w170-rw" aria-hidden="true">
@brunodles brunodles added the enhancement New feature or request label Aug 6, 2018
@Prsna23
Copy link

Prsna23 commented Oct 26, 2019

Hey, I think I will be able to contribute here. Can you please point me to the place where it needs a fix?

@brunodles
Copy link
Owner Author

Hey @Prsna23 sorry for delay, this project is almost dead.
I'm not maintaining it for about a year.

For this issue we should create a new transformer for this @UrlFixer.
But right now it involves refactoring the way I used to invoke the transformer. because it's only getting the result of previous transformer.

Thanks for the interest.
I removed the #hacktoberfest tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants