Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed case vs. lower case #40

Open
wassimj opened this issue Feb 23, 2022 · 2 comments
Open

Mixed case vs. lower case #40

wassimj opened this issue Feb 23, 2022 · 2 comments

Comments

@wassimj
Copy link

wassimj commented Feb 23, 2022

I noticed in the property names sometimes it uses MixedCase and sometimes it uses lowercase. For example, StyleName vs. stylename.

@brunopostle
Copy link
Owner

The lowercase attributes are the internal cellcomplex data, so I never expected them to be exposed. It makes sense to unify them.

I'm giving all the Cells and Faces a unique index number (starting at 0), and putting this in the 'index' attribute. Presumably @wassimj you often need to do the same thing, what namespace do you use?

@wassimj
Copy link
Author

wassimj commented Feb 23, 2022

I do not have index numbers simply because I can retrieve adjacencies through an API call rather than through lookup in dictionaries. For dictionary keys that Topologic is creating 'on the fly' (i.e. from Blender geometry), I am using uppercase TOPOLOGIC followed by underscore followed by lowercase key name. (e.g. TOPOLOGIC_name, TOPOLOGIC_color, TOPOLOGIC_type). For the IFC values that are not in property sets (e.g. name, globalid, type), I prefix with IFC followed by underscore followed by lowercase key name (e.g. IFC_globalid, IFC_name)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants