Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass base URL as CLI argument #16

Closed
mbrodala opened this issue Mar 7, 2018 · 4 comments
Closed

Pass base URL as CLI argument #16

mbrodala opened this issue Mar 7, 2018 · 4 comments

Comments

@mbrodala
Copy link
Contributor

mbrodala commented Mar 7, 2018

Similar to https://github.com/symm/vape it should be possible to pass the base URL for smoke tests as CLI argument instead of hardcoding it in the .cigar.json.

This is essential for running the same batch of checks against multiple environments of the same project, e.g. staging and production.

Currently one can work around this with multiple files named after the environments and passing them to the CLI accordingly but this can quickly become a hassle to manage, especially if the files are not properly kept in sync.

@Brunty
Copy link
Owner

Brunty commented Mar 7, 2018

Good idea!

@Brunty
Copy link
Owner

Brunty commented Mar 12, 2018

@mbrodala version 1.6 has this :) https://github.com/Brunty/cigar/releases/tag/1.6

@mbrodala
Copy link
Contributor Author

You are awesome. :-) This comes at the perfect time since this was preventing me from using cigar and just now I had a case where a smoke test would have prevented an error going live.

tl;dr: 👍

@Brunty
Copy link
Owner

Brunty commented Mar 12, 2018

@mbrodala you're more than welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants