Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokemon without IV on livemap(100%) #284

Open
pki0 opened this issue May 12, 2017 · 5 comments
Open

Pokemon without IV on livemap(100%) #284

pki0 opened this issue May 12, 2017 · 5 comments
Labels

Comments

@pki0
Copy link
Collaborator

pki0 commented May 12, 2017

Bug:

Pokemon without IV are on the live maps even if you set slider to 100%

Maybe fixable in #275 .

aru.php function maybe needs a rewrite because of this bug and freeze with #275

@pki0 pki0 changed the title Pokemon without IV on livemap Pokemon without IV on livemap(100%) May 12, 2017
@friscoMad
Copy link
Collaborator

It is not that easy unless we create a new variable configuration, as there is no easy way to know if the poke or instance has the encounter activated.
To avoid this all pokes without encounter info are shown right now.
The best solution I can think of is using the same configuration as encounter in RM and use that info in ARU to correctly filter pokes.

@pki0
Copy link
Collaborator Author

pki0 commented May 12, 2017

Hmm what about:

Slider at minIV = 80%:

Mysql:
SELECT * FROM pokemon WHERE ... HAVING IV > minIV

Slider at 0%

Mysql:
SELECT * FROM pokemon WHERE ... HAVING IV > minIV OR NULL

PHP:
if (!data->iv){
iv = 0
}

This should display failed/non encounters at minIV = 0

@pki0
Copy link
Collaborator Author

pki0 commented May 12, 2017

And with changing this we can only ask live pokemon in the rectangle we have zoomed the map. Should work.

@friscoMad
Copy link
Collaborator

The problem with that solution is that changing the IV bar for any poke specie that it is not encountered will hide everything, and we will need to update the default minIV to 0.
Another option is doing a query to check if there is any poke with IV and use that as a switch to hide the IV select bar and change the request to aru to use one query of the other.

@friscoMad
Copy link
Collaborator

After checking the source for another thing I did found that there is already such test (only filter by IV where there are IVs stored) so there is no problem in doing that a proper query where null = 0.

Also I think it will be great that the same check could be used to hide the filter bar in the frontend when there are not IV stored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants