Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not close Swipebox #384

Closed
CDT-Nico opened this issue Jan 7, 2021 · 1 comment
Closed

Can not close Swipebox #384

CDT-Nico opened this issue Jan 7, 2021 · 1 comment

Comments

@CDT-Nico
Copy link

CDT-Nico commented Jan 7, 2021

The closeSlide action does not have preventDefault() andstopPropagation(), so clicking the Close button may trigger Swipebox to open again if a binded Swipebox element is below the Close button.

You can see this happening in the Swipebox Project Page it here:

http://youtu.be/dJWy5xoQO5I?hd=1

My suggested solution is to change this line :
$( '#swipebox-close' ).bind( action, function() {

for this:
$( '#swipebox-close' ).bind( action, function( event ) {
event.preventDefault();
event.stopPropagation();

Thanks

@CDT-Nico
Copy link
Author

CDT-Nico commented Jan 7, 2021

I've just seen this is a duplicate of: #324 from 2017!!
How can this not be merged yet?

@CDT-Nico CDT-Nico closed this as completed Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant