Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip_leading_dir option is not working #19

Closed
hgilani opened this Issue May 10, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@hgilani
Copy link

hgilani commented May 10, 2012

Tested strip_leading_dir option with action install and it does not seem to be working. I am getting same results with this option turned on or off.

I drilled inside the code and following section of code seems to be culprit is what it boils down. If and else block seem to be working fine but both result in same directory structure.

      if new_resource.strip_leading_dir
        require 'tmpdir'
        tmpdir = Dir.mktmpdir
        cmd = Chef::ShellOut.new("unzip  -q -u -o '#{new_resource.release_file}' -d '#{tmpdir}'")
        cmd.run_command
        cmd.error!
        subdirectory_children = Dir.glob("#{tmpdir}/**")
        FileUtils.mv subdirectory_children, new_resource.path
        FileUtils.rm_rf tmpdir
      else
        cmd = Chef::ShellOut.new("unzip  -q -u -o #{new_resource.release_file} -d #{new_resource.path}")
        cmd.run_command
        cmd.error!
      end
@bryanwb

This comment has been minimized.

Copy link
Owner

bryanwb commented May 21, 2012

That's definitely bug, am working on it

@bryanwb

This comment has been minimized.

Copy link
Owner

bryanwb commented May 22, 2012

fixed eb7c3ef

@bryanwb bryanwb closed this May 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.