Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Wikilink #427

Closed
tordans opened this issue Sep 7, 2020 · 2 comments
Closed

Improve Wikilink #427

tordans opened this issue Sep 7, 2020 · 2 comments

Comments

@tordans
Copy link

tordans commented Sep 7, 2020

I tested the MVP wikilink feature on the all-tags-view and I really like it. It helps a lot to be able to quickly check the wiki for details of eg. surface-values (the example pictures); or to check, if at tag like ramp=yes is the right way to map it.

I have two main issues with the current implementation

  1. The click area is broken. One can click at the small area below an imput an still trigger the wiki-url-open.
    Possible solution: The click area should only be the icon (arrow).

  2. The arrows on AllTags + CommonTags look the same but behave very differently. Since I use both views a lot, this is confusing.
    Possible solution: The icon should be something more descriptive than an arrow; and not be reuse for something else somewhere else.

  3. It would be great to access the Wiki links on the CommonTags as well; but IMO not too important.

Ideas for a solution:

How about moving the wiki link to the drag action?
image

The primary action would be to delete the value (continue drag or tab the option). The secondary action to open the wiki (tab the option).

I think such an option is better, than adding an icon to each row since this would clutter the UI.
Other ways to avoid the clutter could be to only show actions once the row is active (like cursor in the input), but that’s more complex from a UI point of view IMO.

@wtimme
Copy link
Contributor

wtimme commented Sep 7, 2020

I agree that the current solution can be improved.

How about moving the wiki link to the drag action?

I love it, but it looks like these actions have only been introduced with iOS 11. So if we were to use these actions, we would need to either drop iOS 9/10 support, or have two alternative ways of interacting with the wiki links.

@bryceco
Copy link
Owner

bryceco commented Nov 17, 2020

Here's my attempt to improve this. While putting the actions in the drag action saves space, I'm concerned about whether it's sufficiently discoverable? I personally rarely drag items:
IMG_3684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants