Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional serde support for SymmetricKey, AsymmetricSecretKey and AsymmetricPublicKey #26

Closed
not-my-profile opened this issue Oct 21, 2021 · 4 comments · Fixed by #71
Closed

Comments

@not-my-profile
Copy link
Contributor

I think allowing the keys to be serialized to and deserialized from PASERK strings would make sense.

This would be a follow up to #23.

@brycx
Copy link
Owner

brycx commented Oct 21, 2021

Yes, I've been thinking about this as well. I'm writing up some thoughts on your PR comments right now. Will submit in a few.

@SanchithHegde
Copy link
Contributor

I'd like to pick this up, is there any more information that I'd need?

If you're okay with it, I'd like to contribute support for the remaining PASERK key types, maybe sometime later. Picking this up should get me accustomed to the codebase.

@brycx
Copy link
Owner

brycx commented Oct 7, 2022

Hi @SanchithHegde,

Great to hear you're interested in this!

[..] is there any more information that I'd need?

I don't know how comfortable you are with Rust, but I'll try to collect what I think the initial thoughts were here. This issues scope includes at least the standard PASERK formats kn.local/kn.secret/kn.public. serde support should also be gated behind a feature flag, which should require the flag paserk to be enabled as well (this is a smaller detail).

Additionally, it would probably also be worthwhile to add the optional serde support for the Id struct that enables PASERK IDs.

Regarding adding support for other PASERK formats, this would also be nice to have added. Though we should probably have a look at them and prioritize those that make more sense to support first, compared to others. Further, that ought to go into a different issue if we start this up.

If you have any other questions now or later, feel free to ping me.

@SanchithHegde
Copy link
Contributor

This issues scope includes at least the standard PASERK formats kn.local/kn.secret/kn.public. serde support should also be gated behind a feature flag, which should require the flag paserk to be enabled as well (this is a smaller detail).

Additionally, it would probably also be worthwhile to add the optional serde support for the Id struct that enables PASERK IDs.

Thanks for specifying the requirements, I'll work on it.

Regarding adding support for other PASERK formats, this would also be nice to have added. [...] Further, that ought to go into a different issue if we start this up.

That is indeed what I had in mind as well, let's take it up on a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants