Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript typing bugs #1098

Closed
matsbryntse opened this issue Jun 30, 2020 · 0 comments
Closed

Typescript typing bugs #1098

matsbryntse opened this issue Jun 30, 2020 · 0 comments
Labels
bug Something isn't working docs Improvements or additions to documentation forum Issues from forum
Milestone

Comments

@matsbryntse
Copy link
Member

Forum post

BryntumWidgetAdapterRegister is missing a declaration

BryntumWidgetAdapter's declaration is blank

TaskModelConfig only has one field, listeners

This may not be a bug, but it would still be convenient to export the Config types, e.g. TaskModelConfig + ProjectModelConfig

MessageDialog.confirm says it is returning void, though it should return a Promise based on its implementation. Type def:

export class MessageDialog extends Popup {
    constructor(config?: Partial<MessageDialogConfig>);
    static confirm(options: object): void;
} 

Implementation returns:

return me.promise = new Promise(resolve => {
  me.resolve = resolve;
});

yesButton, noButton, and cancelButton should also probably be added to the MessageDialog type.

@matsbryntse matsbryntse added bug Something isn't working docs Improvements or additions to documentation forum Issues from forum labels Jun 30, 2020
@matsbryntse matsbryntse added this to the Gantt 2.1.6 milestone Jun 30, 2020
@matsbryntse matsbryntse modified the milestones: Gantt 2.1.6, Gantt 2.1.7 Jul 13, 2020
@matsbryntse matsbryntse modified the milestones: Gantt 2.1.7, Gantt 2.1.8 Jul 27, 2020
@isglass isglass modified the milestones: Gantt 2.1.8, Gantt 2.1.9 Aug 10, 2020
@isglass isglass modified the milestones: Gantt 2.1.9, Gantt 4.0.1 Aug 17, 2020
@isglass isglass closed this as completed Oct 20, 2020
@SergeyMaltsev SergeyMaltsev modified the milestones: Gantt 4.0.1, 4.0.1 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Improvements or additions to documentation forum Issues from forum
Projects
None yet
Development

No branches or pull requests

3 participants