Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reordering records fires inconsistent events #1602

Open
pmiklashevych opened this issue Oct 1, 2020 · 0 comments
Open

Reordering records fires inconsistent events #1602

pmiklashevych opened this issue Oct 1, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@pmiklashevych
Copy link

pmiklashevych commented Oct 1, 2020

move function changes records order, fires move event, doesn't reset sorting.
http://lh/master/bryntum-suite/grid/examples/rowreordering/
Sort by Name column, run grid.store.move(grid.store.last, grid.store.first), see record is moved, sorting is kept.
Also fires change event with "move" action which is not described in the list of possible actions.

At the same time RowReorder feature changes records order when you drag and drop a row (record), fires change event with "add" action and index/oldIndex params (need to add the info about action to the feature docs, change event is already described), resets sorting (correct)

In both cases should be fired the same events, and sorting should be reset.

Forums:
https://www.bryntum.com/forum/viewtopic.php?p=77584#p77584
https://www.bryntum.com/forum/viewtopic.php?p=81162#p81162

@pmiklashevych pmiklashevych added the bug Something isn't working label Oct 1, 2020
@isglass isglass added this to the Grid 4.0.x milestone Oct 1, 2020
@isglass isglass modified the milestones: Grid 4.0.x, 4.0.x Nov 18, 2020
@SergeyMaltsev SergeyMaltsev modified the milestones: 4.0.x, 4.1.x Feb 18, 2021
@matsbryntse matsbryntse removed this from the 4.1.x milestone Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants