Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSP Export 2013 compatibility #1745

Closed
fabiojpoli opened this issue Oct 26, 2020 · 2 comments
Closed

MSP Export 2013 compatibility #1745

fabiojpoli opened this issue Oct 26, 2020 · 2 comments
Assignees
Labels
bug Something isn't working resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@fabiojpoli
Copy link

After fix the MSP Export for 2019 version (https://github.com/bryntum/bryntum-suite/pull/2274/files), the 2013 version is not working as was before.

Suggestion is create a condition to work for 2013:
If config version is about 2019 version, apply the changes about pull request above, because the version 2013 was working before that.

2013 currently (after pull request changes above):
Снимок экрана от 2020-10-26 17-52-48

@fabiojpoli fabiojpoli added the bug Something isn't working label Oct 26, 2020
@fabiojpoli fabiojpoli added this to the Gantt 4.0.1 milestone Oct 26, 2020
@fabiojpoli fabiojpoli self-assigned this Oct 27, 2020
@fabiojpoli fabiojpoli added testing info requested Further information is requested labels Oct 27, 2020
@fabiojpoli
Copy link
Author

fabiojpoli commented Oct 28, 2020

Version parameter created.

@arcady-zherdev , please test on the branch 1745-... with your MS Project 2013 version. To do that, please change the exporter configuration at Gantt/examples/msprojectexport/app.js:

const gantt = new Gantt({
    features : {
        mspExport : {
            msProjectVersion : 2013
        }
    },
    ...
});

If there is any problem, please assign it back to me with the screenshot problem. Thank you!

@fabiojpoli
Copy link
Author

According Arcady tests, looks good, data matches:
Снимок экрана от 2020-11-02 18-05-16

@fabiojpoli fabiojpoli added ready for review Issue is fixed, the pull request is being reviewed and removed info requested Further information is requested testing in progress labels Nov 2, 2020
@matsbryntse matsbryntse modified the milestones: Gantt 4.0.1, Gantt 4.0.2 Nov 3, 2020
@fabiojpoli fabiojpoli added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Nov 3, 2020
@SergeyMaltsev SergeyMaltsev modified the milestones: Gantt 4.0.2, 4.0.2 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

4 participants