Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group renderer for timeaxis column duplicates content on group collapse #1751

Closed
matsbryntse opened this issue Oct 27, 2020 · 1 comment
Closed
Assignees
Labels
bug Something isn't working forum Issues from forum resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@matsbryntse
Copy link
Member

Forum post

Trying to render text on the group header row on the time axis column seems to be glitchy after you collapse and expand a group. See picture below.
bug.png
Here I collapsed Amsterdam and expanded it again afterwards. Notice the "Test123" is still floating where Nijmegen used to be.

Code:

const scheduler = new bryntum.scheduler.Scheduler({
    appendTo: 'scheduler',
    columns: [ 
        { 
            text: 'Name', 
            field: 'name'
        },
        { 
            text: 'Location', 
            field: 'location',
        },
    ],
    resources: [
        {
            id: 1,
            name: 'Test1',
            location: 'Nijmegen'
        },
        {
            id: 2,
            name: 'Test2',
            location: 'Nijmegen'
        },
        {
            id: 3,
            name: 'Test3',
            location: 'Nijmegen'
        },
        {
            id: 4,
            name: 'Test4',
            location: 'Amsterdam'
        },
        {
            id: 5,
            name: 'Test5',
            location: 'Amsterdam'
        }
    ],
    features : {
        group : {
            field : 'location',
            renderer : ({ isFirstColumn, column, count, groupRowFor, record }) => {
                if(isFirstColumn) {
                    return `${groupRowFor} (${count})`;
                }
                else if (column instanceof bryntum.scheduler.TimeAxisColumn) {
                    return 'Test123'
                }
                else {
                    return '';
                }
            }
        },
    }
});

@matsbryntse matsbryntse added bug Something isn't working forum Issues from forum labels Oct 27, 2020
@isglass isglass added this to the Scheduler 4.0.x milestone Oct 27, 2020
@isglass isglass modified the milestones: Scheduler 4.0.x, 4.0.x Nov 18, 2020
@SergeyMaltsev SergeyMaltsev modified the milestones: 4.0.x, 4.1.x Feb 18, 2021
@matsbryntse matsbryntse removed this from the 4.1.x milestone Jun 22, 2021
@egorkel-altexsoft
Copy link

I faced the same issue. You can reproduce it on your example https://www.bryntum.com/products/scheduler/examples/grouping

  1. Hide the resource panel using splitter
  2. Collapse and expand the top group
  3. You will see the phantom header of the bottom group
    image

Also, when the resource panel is hidden vertical alignment of the group headers is broken.

Could you please fix it or suggest a workaround for now?

@matsbryntse matsbryntse self-assigned this Jun 30, 2023
@matsbryntse matsbryntse added ready for review Issue is fixed, the pull request is being reviewed resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Jun 30, 2023
@matsbryntse matsbryntse added this to the 5.4.1 milestone Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

4 participants