Wrong baselines dates should not cause crash

[jsakalos]

Forum post

If a baseline endDate is before baseline startDate the app crashes.

To reproduce use the following app.js in place of examples/baselines/app.js. When startDate is swapped with endDate (in both baselines data), it works.

The application should not crash but we should handle the situation somehow, probably by console warning about the integrity of data. Or otherwise but not crash.

import '../_shared/shared.js'; // not required, our example styling etc.
import DateHelper from '../../lib/Core/helper/DateHelper.js';
import Gantt from '../../lib/Gantt/view/Gantt.js';
import ProjectModel from '../../lib/Gantt/model/ProjectModel.js';
import ResourceStore from '../../lib/Gantt/data/ResourceStore.js';
import TaskStore from '../../lib/Gantt/data/TaskStore.js';
import AssignmentStore from '../../lib/Gantt/data/AssignmentStore.js';
import DependencyStore from '../../lib/Gantt/data/DependencyStore.js';
import '../../lib/Grid/feature/Filter.js';
import '../../lib/Gantt/column/WBSColumn.js';
import '../../lib/Gantt/feature/Baselines.js';
import '../../lib/Gantt/feature/Rollups.js';
import '../../lib/Gantt/feature/Labels.js';
import '../../lib/Gantt/feature/ProjectLines.js';
import '../../lib/Gantt/feature/TaskEdit.js';

function setBaseline(index) {
    gantt.taskStore.setBaseline(index);
}

function toggleBaselineVisible(index, visible) {
    gantt.element.classList[visible ? 'remove' : 'add'](
        `b-hide-baseline-${index}`
    );
}

const taskStore = new TaskStore({
    data: [
        {
            id: '123123',
            isResource: true,
            name: 'AAA',
            children: [
                {
                    id: 3101,
                    name: 'Task 1',
                    endDate: '2021-02-18T06:27:18.900Z',
                    startDate: '2021-02-17T12:11:18.900Z',
                    resourceId: 12,
                    rollup: true,
                    manuallyScheduled: false,
                    dependencies: null,
                    baselines: [
                        {
                            startDate: '2021-02-18T10:58:33.505Z',
                            endDate: '2021-02-16T02:00:00.000Z'
                        }
                    ],
                    cls: 'task-status-2',
                    taskStatusName: 'Runned'
                },
                {
                    id: 3155,
                    name: 'Task 2',
                    endDate: '2021-02-19T08:42:18.900Z',
                    startDate: '2021-02-18T06:27:18.900Z',
                    resourceId: 12,
                    rollup: true,
                    manuallyScheduled: false,
                    baselines: [
                        {
                            startDate: '2021-02-18T10:58:33.505Z',
                            endDate: '2021-02-17T04:00:00.000Z'
                        }
                    ],
                    cls: 'task-status-5',
                    taskStatusName: 'To finish'
                }
            ],
            resourceId: 12
        }
    ]
});

const resourcesStore = new ResourceStore({
    data: [
        {
            id: 12,
            name: 'AAA'
        }
    ]
});

const assignmentStore = new AssignmentStore({
    data: [
        {
            eventId: 3101,
            resourceId: 12
        },
        {
            eventId: 3155,
            resourceId: 12
        }
    ]
});

const dependencyStore = new DependencyStore({
    data: [
        {
            toTask: 3155,
            fromTask: 3101,
            type: 2
        }
    ]
});
// Project contains all the data and is responsible for correct scheduling
const project = new ProjectModel({
    taskStore: taskStore,
    resourceStore: resourcesStore,
    assignmentStore: assignmentStore,
    dependencyStore: dependencyStore
    // projectStart: '2021-02-15'
});

const gantt = new Gantt({
    appendTo: 'container',

    dependencyIdField: 'wbsCode',

    project,

    columns: [{ type: 'wbs' }, { type: 'name' }],

    subGridConfigs: {
        locked: {
            flex: 1
        },
        normal: {
            flex: 2
        }
    },

    // Allow extra space for baseline(s)
    rowHeight: 60,

    features: {
        baselines: true,
        columnLines: false,
        filter: true,
        labels: {
            left: {
                field: 'name',
                editor: {
                    type: 'textfield'
                }
            }
        }
    },

    tbar: {
        items: [
            {
                type: 'checkbox',
                text: 'Show baselines',
                checked: true,
                toggleable: true,
                onAction({ checked }) {
                    gantt.features.baselines.disabled = !checked;
                }
            }
        ]
    }
});