Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskEditor tab configuration in beforeTaskEditShow does not work correct #2488

Closed
pmiklashevych opened this issue Mar 4, 2021 · 2 comments
Closed
Assignees
Labels
bug Something isn't working forum Issues from forum resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@pmiklashevych
Copy link

pmiklashevych commented Mar 4, 2021

https://www.bryntum.com/forum/viewtopic.php?p=83712#p83712

http://lh/bryntum-suite/gantt/examples/advanced/

Run in console:

gantt.on({
    beforeTaskEditShow({ editor }) {
        editor.widgetMap.notesTab.hidden = false;
    }
})

Edit a task. See, it makes the tab active and there is no content.

Снимок экрана 2021-03-04 в 21 01 59

@pmiklashevych pmiklashevych added bug Something isn't working regression Worked previously, now broken labels Mar 4, 2021
@pmiklashevych pmiklashevych added this to the 4.1.0 milestone Mar 4, 2021
@ExtAnimal
Copy link

ExtAnimal commented Mar 5, 2021

The TaskEditorBase class has code which sets the heights of all the child items the first time the generalTab is shown.

It is never shown in this case, because that listener forces the notesTab to be shown first, so the tabs never get heighted.

somebody has to decide how the task editor is heighted.

We had decided that the general tab was going to do this job because we assumed that it was always shown.

We'll have to stop wimping out and have an opinion now.

@ExtAnimal ExtAnimal removed the regression Worked previously, now broken label Mar 5, 2021
@pmiklashevych
Copy link
Author

@ExtAnimal Just created a new ticket about this specific problem based on user report #2493

@fabiojpoli fabiojpoli self-assigned this Mar 29, 2021
@matsbryntse matsbryntse modified the milestones: 4.1.0, 4.1.1 Mar 30, 2021
@pmiklashevych pmiklashevych added the forum Issues from forum label Apr 6, 2021
@fabiojpoli fabiojpoli added ready for review Issue is fixed, the pull request is being reviewed resolved Fixed but not yet released (available in the nightly builds) and removed in progress ready for review Issue is fixed, the pull request is being reviewed labels Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

4 participants