Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Id collision happens when you add or move records after filters are cleared #330

Closed
rootcause bot opened this issue Feb 20, 2020 · 2 comments
Closed

Id collision happens when you add or move records after filters are cleared #330

rootcause bot opened this issue Feb 20, 2020 · 2 comments
Assignees
@pmiklashevych
Labels
high-priority Urgent to have fixed resolved Fixed but not yet released (available in the nightly builds) Runtime Error
Milestone
2.1.0

Comments

@rootcause
Copy link

rootcause bot commented Feb 20, 2020

Id collision on _generated_0x422c2b1

Occurred: 5 times
URL: https://www.bryntum.com/examples/gantt/advanced/
Open in Rootcause

An error was logged by RootCause:

Stack trace:
TaskStore$1.loadData at https://www.bryntum.com/examples/build/gantt.module.js?439331:21:126386
TaskStore$1.loadData at https://www.bryntum.com/examples/build/gantt.module.js?439331:178:325792
TaskStore$1.set data at https://www.bryntum.com/examples/build/gantt.module.js?439331:21:124355
TaskStore$1.fillFromMaster at https://www.bryntum.com/examples/build/gantt.module.js?439331:21:94425
TaskStore$1.onMasterDataChanged at https://www.bryntum.com/examples/build/gantt.module.js?439331:21:95482
TaskStore$1.trigger at https://www.bryntum.com/examples/build/gantt.module.js?439331:9:240833
TaskStore$1.onNodeAddChild at https://www.bryntum.com/examples/build/gantt.module.js?439331:21:99051
? at https://www.bryntum.com/examples/build/gantt.module.js?439331:21:21952
Array.forEach at <anonymous>:null:null
ProjectModel.internalAppendInsert at https://www.bryntum.com/examples/build/gantt.module.js?439331:21:21706
@matsbryntse matsbryntse added this to the Gantt 2.0.4 milestone Feb 20, 2020
@matsbryntse matsbryntse added the high-priority Urgent to have fixed label Feb 20, 2020
@matsbryntse matsbryntse modified the milestones: Gantt 2.0.4, Gantt 2.1.0 Feb 21, 2020
@pmiklashevych pmiklashevych self-assigned this Feb 25, 2020
@pmiklashevych
Copy link

pmiklashevych commented Feb 25, 2020 •
edited

Steps to reproduce:
http://lh/bryntum-suite/gantt/examples/advanced/

  1. Filter tasks
  2. Clear filters
  3. Start editing predecessors
  4. Add a new task

Gantt/tests/examples/advanced.t.js

    t.chain([
        { contextmenu : '.b-grid-row[data-id="1000"] [data-column="name"]' },
        { click : '.b-menuitem[data-ref="filterStringEquals"]' },
        { contextmenu : '.b-grid-row[data-id="1000"] [data-column="name"]' },
        { click : '.b-menuitem[data-ref="filterRemove"]' },
        { dblclick : '.b-grid-row[data-id="1000"] [data-column="predecessors"]' },
        { click : '.b-button[data-ref="addTaskButton"]' }
    ]);

@pmiklashevych
Copy link

Another issue related to the filtering problem:

  • Filter.
  • Clear filters.
  • Drag "Run Tests" upwards by two rows.
    There are two of them now!

Screenshot 2020-02-25 at 17 03 02

@pmiklashevych pmiklashevych self-assigned this Mar 4, 2020
@matsbryntse matsbryntse modified the milestones: Gantt 2.1.0, Gantt 2.1.1 Mar 6, 2020
@pmiklashevych pmiklashevych changed the title Runtime Error: "Id collision on _generated_0x422c2b1 Id collision happens when you add or move records after filters are cleared Mar 6, 2020
@pmiklashevych pmiklashevych added ready for review Issue is fixed, the pull request is being reviewed and removed in progress labels Mar 6, 2020
@matsbryntse matsbryntse added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Mar 6, 2020
@matsbryntse matsbryntse modified the milestones: Gantt 2.1.0, Gantt 2.1.1 Mar 10, 2020
@matsbryntse matsbryntse modified the milestones: Gantt 2.1.1, Gantt 2.1.0 Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmiklashevych pmiklashevych

Labels
high-priority Urgent to have fixed resolved Fixed but not yet released (available in the nightly builds) Runtime Error
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@matsbryntse @pmiklashevych