Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State tracking manager logs incorrect steps when adding new event #3530

Closed
chuckn0rris opened this issue Oct 8, 2021 · 3 comments
Closed
Assignees
Labels
bug Something isn't working forum Issues from forum resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@chuckn0rris
Copy link

Forum post

https://bryntum.com/examples/scheduler/undoredo/

Try to add new event, check logs. See 'Updated event "Your new event name"' instead of "Added new event".

transaction.type returns UpdateAction type instead of AddAction, so it is not possible now to determine if an event

Another moment, create an event using dblclick, type a name, click save.
Try to Undo your changes. See that 2 steps logged, frist one will revert event name, second one removes an event.
Try the same using dragCreate, 3 steps recorded.
See that frist Undo will cnagne the name, second one make an event smaller, 3rd one will remove an event.

@chuckn0rris chuckn0rris added bug Something isn't working forum Issues from forum labels Oct 8, 2021
@isglass isglass added this to the 4.3.1 milestone Oct 8, 2021
@SergeyMaltsev SergeyMaltsev modified the milestones: 4.3.1, 4.3.2 Oct 21, 2021
@matsbryntse matsbryntse modified the milestones: 4.3.2, 4.3.3 Oct 31, 2021
@matsbryntse matsbryntse modified the milestones: 4.3.3, 4.3.4 Nov 30, 2021
@isglass isglass changed the title State tracking manager logs incorrect steps when add new event State tracking manager logs incorrect steps when adding new event Dec 2, 2021
@matsbryntse matsbryntse modified the milestones: 4.3.4, 4.3.5 Dec 13, 2021
@matsbryntse matsbryntse modified the milestones: 4.3.5, 4.3.6 Dec 24, 2021
@SergeyMaltsev SergeyMaltsev modified the milestones: 4.3.6, 4.3.7 Jan 14, 2022
@isglass isglass modified the milestones: 4.3.7, 4.3.8, 4.3.9 Feb 1, 2022
@SergeyMaltsev SergeyMaltsev modified the milestones: 4.3.9, 4.3.10 Feb 17, 2022
@isglass isglass modified the milestones: 4.3.10, 5.0.x Feb 18, 2022
@SergeyMaltsev SergeyMaltsev modified the milestones: 5.0.x, 5.1.x Jul 21, 2022
@SergeyMaltsev SergeyMaltsev modified the milestones: 5.1.x, 5.2.x Oct 13, 2022
@isglass isglass removed this from the 5.2.x milestone Feb 20, 2023
@canonic-epicure canonic-epicure self-assigned this Jun 6, 2023
@canonic-epicure
Copy link

canonic-epicure commented Jun 6, 2023

I believe this has been fixed recently in #6699, I'll double check and close the ticket.

@canonic-epicure
Copy link

So this part

Try the same using dragCreate, 3 steps recorded.
See that frist Undo will cnagne the name, second one make an event smaller, 3rd one will remove an event.

was fixed in #6699, but this part wasn't:

Another moment, create an event using dblclick, type a name, click save.
Try to Undo your changes. See that 2 steps logged, frist one will revert event name, second one removes an event.

@canonic-epicure
Copy link

Regarding

Try to add new event, check logs. See 'Updated event "Your new event name"' instead of "Added new event".
transaction.type returns UpdateAction type instead of AddAction, so it is not possible now to determine if an event

This is up to the user how to implement transaction title calculation. In our demo we only look at the last action of the transaction and it case of drag-create it will be "edit event". User can implement a better function, that will be checking the 1st action of the transaction as well, which will be "add event". So this we are not going to address.

@canonic-epicure canonic-epicure added ready for review Issue is fixed, the pull request is being reviewed and removed in progress labels Jun 7, 2023
@isglass isglass added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Jun 7, 2023
@isglass isglass added this to the 5.3.7 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

5 participants