Returning false from onBeforeEventEdit does not prevent the editor from showing

[jsakalos]

For Angular we suggest using on-functions instead of listeners object. However, returning false from onBeforeEventEdit does not prevent the default editor from showing. Using listeners with:

  listeners = {
    beforeEventEdit() {
      return false;
    }
  }

does work.

Forum post

Hi,

I replaced the default editor with a custom one just as described in the docs. However, after opening an NgDialog for our own editor and returning false in the function, the default editor still shows up for a split second.

Is this a bug or can I do something to remove that behaviour?

Below you can see some screenshots of the code and the problem I mentioned.

		 bug.mov
					(3.04 MiB) Downloaded 2 times

As you can see in the video, the default editor pops open for just a second and then disappears again. Could you maybe help me with that?

[jsakalos]

This is caused by Angular. The implementation is:

        bryntumEvents.filter(event => this[event] && this[event].observers.length > 0).forEach(event => {
            const uncapitalize = str => str.charAt(0).toLowerCase() + str.slice(1), eventName = str => uncapitalize(str.slice(2));
            bryntumConfig.listeners[eventName(event)] = e => me[event].emit(e);
        });

Angular emit() function always returns undefined regardless of what is returned from the observer.

We have not solution for it at the moment other than installing beforeXxx listeners that do return false on the native scheduler instance in ngAfterViewInit method. See the code here: https://www.bryntum.com/forum/viewtopic.php?p=95473#p95473

[jsakalos]

Related ticket: #2960