Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer for Check Column not called when exporting #3663

Closed
matsbryntse opened this issue Nov 3, 2021 · 7 comments
Closed

Renderer for Check Column not called when exporting #3663

matsbryntse opened this issue Nov 3, 2021 · 7 comments
Assignees
Labels
bug Something isn't working forum Issues from forum resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@matsbryntse
Copy link
Member

Forum post

I am using the Gantt though not sure if this is just a grid thing. If I try to use renderer with a check column it never gets called during export. It exports out a checkbox in excel and I want some text instead. Is there a way to get this to happen?

@matsbryntse matsbryntse added bug Something isn't working forum Issues from forum labels Nov 3, 2021
@ExtAnimal
Copy link

Probably the exporter class could be configured with its own renderers for columns which need special treatment only for exporting.

Rather than use the column's renderer, if it has its own renderer registered for a column use that.

That would save implementing if/else renderers in columns which would have to know who's doing the rendering.

@FlowIT-JIT
Copy link

FlowIT-JIT commented Aug 8, 2023

The column renderers seems to be called only for name, duration, and our read only columns when exporting to Excel. Our renderer is not called for the wbs column, not for our date columns, and not for our checkbox columns. This unfortunately prevents us from using this feature.

@matsbryntse Are you able to prioritize and plan a fix for a patch release in the near future ? I'm fine with the use of args.isExport in the renderer to distinguish between HTML rendering and Excel rendering. - Thanks

EDIT: Renderer was not registered on the wbs column, so ignore that statement.

@matsbryntse matsbryntse self-assigned this Aug 8, 2023
@matsbryntse
Copy link
Member Author

We'll have a look. WBSColumn seems to work fine for me. What version are you on?

@matsbryntse matsbryntse added the ready for review Issue is fixed, the pull request is being reviewed label Aug 8, 2023
@matsbryntse
Copy link
Member Author

For date columns to have your renderer be called, please configure your Export feature with:
exportDateAsInstance : false

@matsbryntse matsbryntse added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Aug 8, 2023
@matsbryntse matsbryntse added this to the 5.5.1 milestone Aug 8, 2023
@FlowIT-JIT
Copy link

@matsbryntse
How do we use this with the Excel Exporter feature? TypeScript definitions have not been updated it seems, so not much help there. I have tried the following approach using https://bryntum.com/products/gantt/examples/exporttoexcel/

image

The renderer is registered for wbs, name, and startDate, and gets called for all three columns when rendering to the screen. But when exporting, the renderer is only called for wbs and name.

@matsbryntse
Copy link
Member Author

Like so:

features : {
       excelExporter : {
         exporterConfig : {
               exportDateAsInstance : false
}

       }
   },

@FlowIT-JIT
Copy link

Thanks, @matsbryntse 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

3 participants