Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition bug when clicked undo/redo fast #3698

Closed
chuckn0rris opened this issue Nov 10, 2021 · 5 comments
Closed

Race condition bug when clicked undo/redo fast #3698

chuckn0rris opened this issue Nov 10, 2021 · 5 comments
Assignees
Labels
bug Something isn't working forum Issues from forum high-priority Urgent to have fixed in progress info requested Further information is requested OEM OEM customer premium
Milestone

Comments

@chuckn0rris
Copy link

chuckn0rris commented Nov 10, 2021

Forum post

Reproduced on https://bryntum.com/examples/gantt/advanced/
Make few changes to have 6-10 steps undo. As example, create 5 events and make dependencies one by one.
Click undo/redo fast, it will throw an error in console:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'get')
    at _0x305c19.equality (gantt.module.js?454302:13)
    at EngineTransaction.onQuarkCalculationCompleted (gantt.module.js?454302:13)
    at EngineTransaction.calculateTransitionsStackGen (gantt.module.js?454302:13)
    at Generator.next (<anonymous>)
    at EngineTransaction.calculateTransitions (gantt.module.js?454302:13)
    at Generator.next (<anonymous>)
    at runGeneratorAsyncWithEffect (gantt.module.js?454302:13)
    at gantt.module.js?454302:13
@chuckn0rris chuckn0rris added bug Something isn't working premium forum Issues from forum OEM OEM customer labels Nov 10, 2021
@matsbryntse matsbryntse added this to the 5.0.1 milestone Nov 11, 2021
@SergeyMaltsev SergeyMaltsev modified the milestones: 5.0.1, 5.0.2 Mar 4, 2022
@matsbryntse matsbryntse added the high-priority Urgent to have fixed label Apr 4, 2022
@SergeyMaltsev SergeyMaltsev modified the milestones: 5.0.2, 5.0.3 Apr 13, 2022
@isglass isglass self-assigned this Apr 22, 2022
@isglass isglass added in progress info requested Further information is requested and removed in progress labels Apr 22, 2022
@isglass
Copy link
Contributor

isglass commented Apr 22, 2022

Could not reproduce it, asked @chuckn0rris to try. Might have been fixed by other changes

@SergeyMaltsev SergeyMaltsev modified the milestones: 5.0.3, 5.0.4 Apr 26, 2022
@isglass isglass assigned arcady-zherdev and unassigned isglass May 3, 2022
@isglass
Copy link
Contributor

isglass commented May 3, 2022

To reproduce:

  1. Open advanced demo
  2. Click + Create twice
  3. Drag create a dependency from the first new tasks end to second ones start
  4. Undo twice
  5. Redo

@isglass isglass removed the info requested Further information is requested label May 6, 2022
@SergeyMaltsev SergeyMaltsev modified the milestones: 5.0.4, 5.0.5 May 11, 2022
@SergeyMaltsev SergeyMaltsev modified the milestones: 5.0.5, 5.0.6 May 30, 2022
@SergeyMaltsev SergeyMaltsev modified the milestones: 5.0.6, 5.0.7 Jun 20, 2022
@SergeyMaltsev SergeyMaltsev modified the milestones: 5.0.7, 5.0.8 Jul 13, 2022
@SergeyMaltsev SergeyMaltsev removed this from the 5.0.8 milestone Jul 21, 2022
@SergeyMaltsev SergeyMaltsev added this to the 5.1.x milestone Jul 21, 2022
@SergeyMaltsev SergeyMaltsev modified the milestones: 5.1.x, 5.2.x Oct 13, 2022
@canonic-epicure
Copy link

Does not seem to be reproducible anymore in the online examples, probably has been already fixed.

@canonic-epicure canonic-epicure added the info requested Further information is requested label Nov 30, 2022
@canonic-epicure
Copy link

Please provide new steps to reproduce.

@matsbryntse
Copy link
Member

Closed until new repro sequence is available

@SergeyMaltsev SergeyMaltsev modified the milestones: 5.2.x, 5.2.6 Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum high-priority Urgent to have fixed in progress info requested Further information is requested OEM OEM customer premium
Projects
None yet
Development

No branches or pull requests

6 participants