Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store.allRecords does not return all records when filtered+grouped #4009

Closed
matsbryntse opened this issue Jan 12, 2022 · 1 comment
Closed

Store.allRecords does not return all records when filtered+grouped #4009

matsbryntse opened this issue Jan 12, 2022 · 1 comment
Assignees
@matsbryntse
Labels
bug Something isn't working forum Issues from forum OEM OEM customer premium resolved Fixed but not yet released (available in the nightly builds)
Milestone
5.6.5

Comments

@matsbryntse
Copy link
Member

Forum post

I have a store with a grouping + filters.
Now I want to retrieve all records (including the ones filtered out) but I'm only getting the non-filtered records, basically the same as store.records.

When I remove the grouping, allRecords does return all records in my store.

Is this a bug?

Looking at the internal bryntum code it looks like collectGroupRecords(true) should be used? But allRecords just calls collectGroupRecords() without the parameter.
@matsbryntse matsbryntse added bug Something isn't working premium forum Issues from forum OEM OEM customer labels Jan 12, 2022
@matsbryntse matsbryntse added this to the 4.3.6 milestone Jan 12, 2022
@matsbryntse matsbryntse self-assigned this Jan 12, 2022
@matsbryntse matsbryntse added ready for review Issue is fixed, the pull request is being reviewed and removed ready for review Issue is fixed, the pull request is being reviewed labels Jan 12, 2022
@matsbryntse matsbryntse removed this from the 4.3.6 milestone Jan 13, 2022
@matsbryntse
Copy link
Member Author

Current contract of allRecords is to not return group headers. Please use collectGroupRecords(true) for now

@matsbryntse matsbryntse removed their assignment Jan 24, 2022
@matsbryntse matsbryntse self-assigned this Dec 31, 2023
@matsbryntse matsbryntse added ready for review Issue is fixed, the pull request is being reviewed resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Dec 31, 2023
@matsbryntse matsbryntse added this to the 5.6.5 milestone Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matsbryntse matsbryntse

Labels
bug Something isn't working forum Issues from forum OEM OEM customer premium resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Milestone
5.6.5
Development

No branches or pull requests
1 participant
@matsbryntse