Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CellEdit instantUpdate regression #4079

Closed
isglass opened this issue Jan 27, 2022 · 0 comments
Closed

CellEdit instantUpdate regression #4079

isglass opened this issue Jan 27, 2022 · 0 comments
Assignees
@ExtAnimal
Labels
bug Something isn't working regression Worked previously, now broken resolved Fixed but not yet released (available in the nightly builds)
Milestone
5.0.0

Comments

@isglass
Copy link
Contributor

isglass commented Jan 27, 2022 •
edited

Reproducible on Gantts advanced demo, try using cell editor in duration column.

It live updates the value but on blur the old cell value first returns and then it changes over to the new value.

Caused by new code in Row#renderCell that blocks update during cell editing:

Screenshot 2022-01-27 at 15 21 10

If I remove that it looks good again.

Even more noticeable when live updating a non engine record, the value then never gets updated since the blur does not actually update the record. Configure the score column in http://lh/bryntum-suite/Grid/examples/celledit/ with instantUpdate: true and edit it
@isglass isglass added bug Something isn't working regression Worked previously, now broken labels Jan 27, 2022
@isglass isglass added this to the 5.0 milestone Jan 27, 2022
@isglass isglass changed the title CellEdit liveUpdate regression CellEdit instantUpdate regression Jan 27, 2022
@ExtAnimal ExtAnimal added ready for review Issue is fixed, the pull request is being reviewed resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Jan 31, 2022
@isglass isglass modified the milestones: 5.0, 5.0.0-beta-1 Feb 18, 2022
@SergeyMaltsev SergeyMaltsev modified the milestones: 5.0.0-beta-1, 5.0.0 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ExtAnimal ExtAnimal

Labels
bug Something isn't working regression Worked previously, now broken resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
3 participants
@ExtAnimal @isglass @SergeyMaltsev