Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of data setting must be enforced when data set through setConfig #4307

Closed
ExtAnimal opened this issue Mar 4, 2022 · 0 comments
Closed
Labels
bug Something isn't working forum Issues from forum resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@ExtAnimal
Copy link

Forum post

The ordering os data setting means that events is added before resources, so when loading the new events, it looks up the old resources in the resourceStore.

Data loading order is highly defined. It's why CrudManager exists. The order is defined in ProjectConsumer, and it probably is possible to have ProjectConsumer implement the data names (['resources', 'events', 'assignments']), as configurable configs, so that each references its previous (so changeEvents calls this.getConfig('resources') to bring the resources in which it relies on)

That would then mean that the WrapperHelper, instead of passing property changes directly in, would gather up all the configs into a newConfigObject, and on a 0 ms timer, call configOrInstance.setConfig(newConfigObject)

But the immediate concern is what change caused this to begin behaving like this. Something must have changed in the wrapper layer. @jsakalos ?

@ExtAnimal ExtAnimal added bug Something isn't working forum Issues from forum labels Mar 4, 2022
@ExtAnimal ExtAnimal changed the title Angular wrapper application of data has changed Order of data setting must be enforced when data set through setConfig Mar 4, 2022
@ExtAnimal ExtAnimal added the resolved Fixed but not yet released (available in the nightly builds) label Mar 7, 2022
@ExtAnimal ExtAnimal added this to the 5.0.2 milestone Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

1 participant