Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs for isValidDependency method to allow pass instances #4431

Closed
chuckn0rris opened this issue Mar 31, 2022 · 1 comment
Closed

Fix docs for isValidDependency method to allow pass instances #4431

chuckn0rris opened this issue Mar 31, 2022 · 1 comment
Assignees
@isglass
Labels
bug Something isn't working forum Issues from forum resolved Fixed but not yet released (available in the nightly builds)
Milestone
5.0.6

Comments

@chuckn0rris
Copy link

Forum post

isValidDependencyToCreate and isValidDependency doesn't work correct if ids passed.
But works in case tasks instances passed, which is not documented. Need to update docs to pass instances and check if it tested well.
@chuckn0rris chuckn0rris added bug Something isn't working forum Issues from forum labels Mar 31, 2022
@isglass
Copy link
Contributor

isglass commented Mar 31, 2022

Make it accept ids too then

@isglass isglass added this to the 5.0.x milestone Mar 31, 2022
@isglass isglass modified the milestones: 5.0.x, 5.0.6 May 30, 2022
@isglass isglass self-assigned this May 30, 2022
@isglass isglass added in progress ready for review Issue is fixed, the pull request is being reviewed resolved Fixed but not yet released (available in the nightly builds) and removed in progress ready for review Issue is fixed, the pull request is being reviewed labels May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isglass isglass

Labels
bug Something isn't working forum Issues from forum resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Milestone
5.0.6
Development

No branches or pull requests
2 participants
@isglass @chuckn0rris