Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering fails if normal region is collapsed initially #48

Closed
matsbryntse opened this issue Nov 25, 2019 · 4 comments
Closed

Rendering fails if normal region is collapsed initially #48

matsbryntse opened this issue Nov 25, 2019 · 4 comments
Labels
bug Something isn't working invalid This doesn't seem right regression Worked previously, now broken

Comments

@matsbryntse
Copy link
Member

Add to basic scheduler sample:


subGridConfigs: {
        locked: { collapsed: false },
        normal: { collapsed: true } // swap these booleans for same issue
    },

Console logs: "No available space provided for time axis. Make sure you have set width for horizontal mode and height for vertical"

@matsbryntse matsbryntse added bug Something isn't working regression Worked previously, now broken labels Nov 25, 2019
@matsbryntse
Copy link
Member Author

@ExtAnimal
Copy link

ExtAnimal commented Nov 27, 2019

The Scheduler's timeAxisSubGrid relies a lot on width.

It initializes itself on first paint (Used to be on render, but that has no meaning as a lifecycle stage now)

But if at first paint time, the width is zero, it cannot initialize itself. It has to put this off until expand.

But the set width part of expand fires events into parts of the machinery which assume everything is all functional. This is in fact now part of the setup phase.

Part of the solution is a proper SubGrid subclass to encapsulate a timeAxisSubGrid which could then have its own specializations.

One of which would be a set width implementation which could route into necessary initialization.

Or an onPaint implementation which would mean TimeLineBase doesn't need its own implementation, and that could decide upon the timing of width initialization.

@ExtAnimal
Copy link

So GridSubGrids#initSubGrids should not do new SubGrid.

It should call me.createSubGrid(subGridConfig) which by default would just create base SubGrid, but subclasses could implement their own ways of instantiating and initializing the sub grids.

@matsbryntse matsbryntse added this to the 4.2.0 milestone May 19, 2021
@matsbryntse matsbryntse removed this from the 4.2.0 milestone Jun 22, 2021
@isglass
Copy link
Contributor

isglass commented Aug 8, 2022

Replaced by #281

@isglass isglass closed this as completed Aug 8, 2022
@isglass isglass added the invalid This doesn't seem right label Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right regression Worked previously, now broken
Projects
None yet
Development

No branches or pull requests

3 participants