Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting autoClose to false doesn't work #4882

Closed
taauntik opened this issue Jul 1, 2022 · 4 comments
Closed

Setting autoClose to false doesn't work #4882

taauntik opened this issue Jul 1, 2022 · 4 comments
Assignees
Labels
bug Something isn't working forum Issues from forum OEM OEM customer premium resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@taauntik
Copy link

taauntik commented Jul 1, 2022

Forum post

Hi, according to scheduler docs:

By default a Popup is transient, and will close when the user clicks or taps outside its owned widgets and when focus moves outside its owned widgets.
Note: Modal popups won't close when focus moves outside even if autoClose is true.
Configure as false to make a Popup non-transient.

So as i understand, if i set 'autoClose: false' on eventTooltip the tooltip will not close as i move or click my mouse outside the tooltip.

as you can see this is not the case:
https://codepen.io/ofirkatz/pen/BaryMmv

@taauntik taauntik added bug Something isn't working premium forum Issues from forum OEM OEM customer labels Jul 1, 2022
@taauntik taauntik changed the title Setting autoClose to false doesn't work Setting autoClose to false doesn't work Jul 1, 2022
@ofirkg
Copy link

ofirkg commented Jul 3, 2022

Hi, showOnHover: false also not working

@ExtAnimal
Copy link

There are some issues with overlap of configs and how they work.

showOnClick is inherited from Popup, and it only works if there is a forElement and always shows on click of the forElement, not taking any forSelector into account. So tooltips cannot really use it.

And in Tooltip showOnHover is automatically set to true if a forSelector is present. So tooltips with a delegate (most of them, it's more efficient) always show on hover, and they cannot use showOnClick

We need to rearrange this a little so that showOnHover is only automatically set to true if it is not passed as a config option. We must not override the developer's setting.

And showOnClick should work with forSelector.

@taauntik
Copy link
Author

User is asking for the fix here https://www.bryntum.com/forum/viewtopic.php?f=51&t=21664&start=10

@matsbryntse matsbryntse self-assigned this Nov 17, 2023
@matsbryntse matsbryntse added the ready for review Issue is fixed, the pull request is being reviewed label Nov 17, 2023
@matsbryntse
Copy link
Member

This is supported by setting hideDelay : false

@matsbryntse matsbryntse added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Nov 20, 2023
@matsbryntse matsbryntse added this to the 5.6.2 milestone Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum OEM OEM customer premium resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

4 participants