Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync not fired when edit Milestone #6214

Closed
chuckn0rris opened this issue Feb 19, 2023 · 2 comments
Closed

Sync not fired when edit Milestone #6214

chuckn0rris opened this issue Feb 19, 2023 · 2 comments
Labels
bug Something isn't working forum Issues from forum not reproducible

Comments

@chuckn0rris
Copy link

Forum post

Steps:
Right click in first task -> Add -> Milestone. See sync request in Network tab.
Right click on Milestone -> Add -> Subtask. See sync request in Network tab.
Double click on new created Subtask, edit name in TaskEditor, Save. See no sync request in Network tab.

Apps for reproduce. Simple server and very simple React app.
To run server: npm i && node index.js
To run app: npm i && npm run start
nodejs_sample (1).zip
gantt_chart_reactjs (1).zip

@chuckn0rris chuckn0rris added bug Something isn't working forum Issues from forum labels Feb 19, 2023
@isglass isglass added the high-priority Urgent to have fixed label Feb 20, 2023
@isglass isglass self-assigned this Mar 3, 2023
@isglass
Copy link
Contributor

isglass commented Mar 3, 2023

Sync response for new tasks has to include a proper id, otherwise they will continue to be considered added, and changes will lead to another add instead of an update.

For example if(req.body.tasks && req.body.tasks.added) { rows_tasks = req.body.tasks.added; rows_tasks.forEach(taskData => { taskData.id = idCounter++; }); }

@isglass isglass removed the high-priority Urgent to have fixed label Mar 3, 2023
@isglass isglass removed their assignment Mar 3, 2023
@chuckn0rris
Copy link
Author

No repro after id fix. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum not reproducible
Projects
None yet
Development

No branches or pull requests

2 participants