Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using 2 overrides for 1 class causes max call stack error #6364

Open
chuckn0rris opened this issue Mar 13, 2023 · 0 comments
Open

Using 2 overrides for 1 class causes max call stack error #6364

chuckn0rris opened this issue Mar 13, 2023 · 0 comments
Labels
bug Something isn't working forum Issues from forum

Comments

@chuckn0rris
Copy link

Forum post

To reproduce try in grid celledit example



class TextFieldOverride {

    static get target(){
        return {
            class: TextField,
        };
    }

    construct(config) {
        if (this.type === TextField.type) {
            config.clearable = true;
        }

        this._overridden.construct.call(this, config);
    }
}
  class CustomerTextFieldOverride {
    static get target(){
        return {
            class: TextField,
        };
    }

    construct(config) {
        if (this.type === TextField.type) {
            config.cls = 'custom-cls';
        }

        this._overridden.construct.call(this, config);
    }
}

Override.apply(TextFieldOverride);
Override.apply(CustomerTextFieldOverride);

Reload the page, start cell editing with textfield editor. See max call stack error in console.

@chuckn0rris chuckn0rris added bug Something isn't working forum Issues from forum labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum
Projects
None yet
Development

No branches or pull requests

1 participant