Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VUE 3] Kebab-case names for Vue wrappers #6455

Open
2 tasks
SergeyMaltsev opened this issue Mar 24, 2023 · 1 comment
Open
2 tasks

[VUE 3] Kebab-case names for Vue wrappers #6455

SergeyMaltsev opened this issue Mar 24, 2023 · 1 comment
Assignees
Labels
bug Something isn't working forum Issues from forum frameworks vue Vue framework integration vue3 Vue 3 framework integration

Comments

@SergeyMaltsev
Copy link
Contributor

SergeyMaltsev commented Mar 24, 2023

Forum post

  • Update wrappers to use kebab case convention for vue events/features.
  • Update guides

Stated here:
https://vuejs.org/guide/components/events.html#emitting-and-listening-to-events

Currently these supported:

Using onFunctions:

<bryntum-calendar
    ref="calendar"
    v-bind="calendarConfig"
    :onBeforeDragMoveEnd="handleBeforeDragMoveEnd"
    :onDragMoveEnd="handleDragMoveEnd"
/>

Using events with camelCase:

<bryntum-calendar
    ref="calendar"
    v-bind="calendarConfig"
    @beforeDragMoveEnd="handleBeforeDragMoveEnd"
    @dragMoveEnd="handleDragMoveEnd"
/>

TODO

Support this

<bryntum-calendar
    ref="calendar"
    v-bind="calendarConfig"
    @before-event-resize="handleBeforeEventResize"
    @before-drag-move-end="handleBeforeDragMoveEnd"
/>
@SergeyMaltsev SergeyMaltsev added bug Something isn't working vue Vue framework integration forum Issues from forum vue3 Vue 3 framework integration frameworks labels Mar 24, 2023
@SergeyMaltsev SergeyMaltsev self-assigned this Mar 24, 2023
@jsakalos
Copy link

We need to support kebab names for ALL configs/props/events because Vue 3 guys strongly recommend that. So on-load in a Vue template has to be transformed to our onLoad config/prop name.

@SergeyMaltsev SergeyMaltsev changed the title [VUE 3] Kebab-case event names for Vue wrappers [VUE 3] Kebab-case names for Vue wrappers Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum frameworks vue Vue framework integration vue3 Vue 3 framework integration
Projects
None yet
Development

No branches or pull requests

2 participants