Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues combining infiniteScroll with zoom #6654

Closed
marciogurka opened this issue Apr 26, 2023 · 3 comments
Closed

Issues combining infiniteScroll with zoom #6654

marciogurka opened this issue Apr 26, 2023 · 3 comments
Assignees
Labels
bug Something isn't working forum Issues from forum high-priority Urgent to have fixed OEM OEM customer premium resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@marciogurka
Copy link

marciogurka commented Apr 26, 2023

Forum post

"We are currently setting up a quite full featured date navigation setup, with moving to dates, zoom in/out buttons, custom preset zoom levels among other things. We also want to use infiniteScroll, but when we enabled that we found that it doesn’t play nice with any of the mentioned features.

We’ve found examples you have of each feature, and I’ll try to describe how the error presents itself in each case. For each of the examples, just add infiniteScroll: true to the scheduler config.

  1. Zooming, for example in https://www.bryntum.com/products/schedulerpro/examples/resourceutilization/. When having all of the event in the viewport, zooming in and out changes the range of dates visible to the future or past, often to the point where no events are visible anymore."
@marciogurka marciogurka added bug Something isn't working premium forum Issues from forum OEM OEM customer labels Apr 26, 2023
@marciogurka marciogurka changed the title Issues combining infiniteScroll with other functionalities Issues combining infiniteScroll with zoom Apr 27, 2023
@matsbryntse matsbryntse added the high-priority Urgent to have fixed label Jun 6, 2023
@marciogurka
Copy link
Author

This behavior perhaps could be the zooming with scrolling that gets the pointer position to zoom in/out the scheduler, asking for more information to the user.

@ExtAnimal
Copy link

It's not "issues". It's not combining infinite scroll and zoom.

That works as well as the current scheme of cycling through ViewPresets can work.

The visual issues are all caused by the presence of the ResourceHistogram.

If you remove that, so that the example is just this:

Screenshot 2023-06-06 at 17 09 36

Then it all works fine.

The ResourceHistogram needs to be refactored. The TimeAxis is of course being changed on every zoom step right now because every zoom step is a ViewPreset change. And that causes a heavy recalculation in the ResourceHistogram widget with many async operations running into the future. And then more zooms arrive before that operation has finished and start it all off again.

And these two widgets are linked by being partnered so that any scroll in one, scrolls the other. I think @arcady-zherdev is the expert on the ResourceHistogram widget. The cascade of operations from every zoom step needs to be tamed.

@arcady-zherdev arcady-zherdev self-assigned this Oct 13, 2023
@arcady-zherdev
Copy link

arcady-zherdev commented Oct 13, 2023

@ExtAnimal turned out to be not specific to the histogram... two scheduler instances give the same issue

@arcady-zherdev arcady-zherdev added in progress ready for review Issue is fixed, the pull request is being reviewed and removed in progress labels Oct 19, 2023
@isglass isglass added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Oct 20, 2023
@isglass isglass added this to the 5.5.5 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum high-priority Urgent to have fixed OEM OEM customer premium resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

5 participants