Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify granularity level of dayStartTime and dayEndTime in API docs #7002

Closed
ExtAnimal opened this issue Jun 14, 2023 · 0 comments
Closed
Assignees
Labels
bug Something isn't working forum Issues from forum resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@ExtAnimal
Copy link

Forum post

We pushed our latest release live on Sunday, with the latest Calendar release, but had to pull it due to complaints from users. The time-rule and the event start times are out of whack.

Images attached.


let calendarDate = calendar.date
    const day = new Date(calendarDate).getDay();
    const dayNames = ["sun", "mon", "tue", "wed", "thu", "fri", "sat"];
    const data =  dmx.parse('_opening_hours.data._list.open_hours')
     calendar.activeView.view.dayStartTime = data[dayNames[day]+"_open"]
     calendar.activeView.view.dayEndTime = data[dayNames[day]+"_close"]
     

time-ruler-fke.jpg
time-ruler-fkd.jpg

@ExtAnimal ExtAnimal added bug Something isn't working forum Issues from forum labels Jun 14, 2023
@ExtAnimal ExtAnimal added this to the 5.4.0-beta-1 milestone Jun 14, 2023
@ExtAnimal ExtAnimal self-assigned this Jun 14, 2023
@ExtAnimal ExtAnimal added the ready for review Issue is fixed, the pull request is being reviewed label Jun 14, 2023
@isglass isglass added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Jun 16, 2023
@SergeyMaltsev SergeyMaltsev modified the milestones: 5.4.0-beta-1, 5.4.0 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

3 participants