Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel height increased when add more items but don't decreased when remove items #7009

Closed
chuckn0rris opened this issue Jun 15, 2023 · 2 comments
Assignees
Labels
bug Something isn't working forum Issues from forum large-account Reported by large customer OEM OEM customer resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@chuckn0rris
Copy link

Forum post

Hi support,

There is an unwanted white space encountered while deleting multiple filters. Please have a look at the video attached.

Unwanted.space.webm

This issue is happening when we try to add more filters those exceed screen size. There is no issue when we add multiple filters within the screen size. Is this an existing issue. Please suggest.

Thanks,
Bharat.

 gantt.current.instance.tbar.add([
        {
          type: 'button',
          ref: 'filterAllButton',
          icon: 'b-gantt-filter',
          tooltip: 'Filter',
          menu: {
            pickergroup: {
              width: 455,
              grid: gantt.current.instance,
              type: 'gridfieldfilterpickergroup',
              fields: [
                { name: 'owner', type: 'string' },
                { name: 'function', type: 'string' },
                { name: 'status', type: 'string' },
              ],
            },
          },
        },
      ]);
@chuckn0rris chuckn0rris added bug Something isn't working forum Issues from forum large-account Reported by large customer OEM OEM customer labels Jun 15, 2023
@emilschutte emilschutte self-assigned this Jun 15, 2023
@emilschutte
Copy link

emilschutte commented Jun 19, 2023

Hi @chuckn0rris, do we have a repro for this? I haven't managed to repro it yet. please disregard, was able to repro it

@emilschutte
Copy link

Doesn't seem to be specific to the filterpicker:

Screen.Recording.2023-06-19.at.16.48.27.mov

Seems to be that the menu/popup is getting its height set to the calculated height when it reaches the edge of the viewport, and after that it never receives a later element resize event, I suppose since the manual height prevents it shrinking to fit its children.

@ExtAnimal ExtAnimal assigned ExtAnimal and unassigned emilschutte Jun 20, 2023
@ExtAnimal ExtAnimal added in progress ready for review Issue is fixed, the pull request is being reviewed and removed in progress labels Jun 20, 2023
@ExtAnimal ExtAnimal added this to the 5.4.0-beta-1 milestone Jun 20, 2023
@isglass isglass added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Jun 20, 2023
@SergeyMaltsev SergeyMaltsev modified the milestones: 5.4.0-beta-1, 5.4.0 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum large-account Reported by large customer OEM OEM customer resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

5 participants