Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature mixin on-owner events are not exposed on class #7092

Closed
marciogurka opened this issue Jun 29, 2023 · 4 comments
Closed

Feature mixin on-owner events are not exposed on class #7092

marciogurka opened this issue Jun 29, 2023 · 4 comments
Assignees
Labels
bug Something isn't working forum Issues from forum high-priority Urgent to have fixed OEM OEM customer react React framework integration resolved Fixed but not yet released (available in the nightly builds) wrappers Framework wrappers integration
Milestone

Comments

@marciogurka
Copy link

Forum post

"Hi,
I'm using Bryntum Gantt and I would like to use event which will be trigger on adding dependencies between two elements in the Gantt (like in the screenshot below).
2023-06-29_13h17_43.png
I tried to use onBeforeDependencyAdd which I found in the code but it was not working.
2023-06-29_13h14_54.png
Do you have idea what kind of trigger can I use ?"

Checking this issue, I noticed that some of the events available here https://bryntum.com/products/gantt/docs/api/Scheduler/feature/Dependencies#events are not available on the React way (using onEventName), so we need to add that.

@marciogurka marciogurka added bug Something isn't working react React framework integration forum Issues from forum OEM OEM customer labels Jun 29, 2023
@marciogurka
Copy link
Author

The following listeners are missing on the React Wrapper

afterDependencyCreateDrop,
beforeDependencyCreateDrag,
beforeDependencyCreateFinalize,
beforeShowTerminals,
dependencyCreateDragStart,
dependencyCreateDrop,
dependencyValidationComplete,
dependencyValidationStart

So the following configuration works

const listeners = {
  afterDependencyCreateDrop: (eventData) => {},
  beforeDependencyCreateDrag: (eventData) => {},
  beforeDependencyCreateFinalize: (eventData) => {},
  beforeShowTerminals: (eventData) => {},
  dependencyCreateDragStart: (eventData) => {},
  dependencyCreateDrop: (eventData) => {},
  dependencyValidationComplete: (eventData) => {},
  dependencyValidationStart: (eventData) => {},
}

but this one doesn't:

<BryntumGantt
  onAfterDependencyCreateDrop={handleEvent}
  ...
/>

@jsakalos
Copy link

Confirmed. The events should be in the wrapper.

@Jmurawsk
Copy link

@marciogurka any update here ? I also found listener which can be added to React Wrapper - dependencyContextMenu

@jsakalos
Copy link

As investigated by @ghulamghousdev these events are really not present in the wrapper. @SergeyMaltsev to check/fix as this seems to be the wrapper generator bug.

@SergeyMaltsev SergeyMaltsev changed the title [React] Missing some dependencies event listeners Feature mixin on-owner events are not exposed on class Nov 21, 2023
@SergeyMaltsev SergeyMaltsev added this to the 5.6.2 milestone Nov 21, 2023
@ghulamghousdev ghulamghousdev added resolved Fixed but not yet released (available in the nightly builds) and removed in progress labels Nov 21, 2023
@isglass isglass closed this as completed Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum high-priority Urgent to have fixed OEM OEM customer react React framework integration resolved Fixed but not yet released (available in the nightly builds) wrappers Framework wrappers integration
Projects
None yet
Development

No branches or pull requests

6 participants