Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event removed when returning false from beforeEventEdit after v5.3.3 #7116

Closed
marciogurka opened this issue Jul 4, 2023 · 0 comments
Closed
Assignees
Labels
bug Something isn't working example forum Issues from forum regression Worked previously, now broken resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@marciogurka
Copy link

marciogurka commented Jul 4, 2023

Forum post

"Hello team!

we are replacing the default event editor in our Scheduler Pro by custom components, preventing the "beforeEventEdit" event:


beforeEventEdit(eventData) {
    // TODO: eventData is also missing resourceRecord from docs: https://bryntum.com/products/schedulerpro/docs/api/Scheduler/feature/EventEdit#event-beforeEventEdit
    console.log(eventData)
    // show custom modal
    return false;
}


This worked just fine with v5.3.3. After upgrading to the latest version (v5.3.5 a few month ago), we encountered a different behavior when creating a new event within the scheduler using actions like dragging or double-clicking. The newly added event is now being immediately removed from the scheduler. Removing the "return false" statement resolves the issue, but it also causes the default editor to be displayed. This issue also applies to the "beforeTaskEdit" event.

Reproduction steps in short:

  1. Install Scheduler Pro newer then v.5.3.3
  2. configure "beforeEventEdit" event listener to be prevented
  3. try to create new event (e.g. via drag)

You'll find reproduction in the attachment.

Currently this issue makes it impossible for us to update to the latest version (5.4.0). Is it a bug? I have been unable to locate any documentation that reflects this particular change in behavior."

There are two videos with the behavior using 5.3.3 and 5.4.0

Also as it's commented, the resourceRecord parameter is missing, but it's available in the docs.

v5.3.3.mp4
v5.4.0.mp4

vue-bryntum-test-editor.zip

@marciogurka marciogurka added bug Something isn't working forum Issues from forum regression Worked previously, now broken BLOCKING example labels Jul 4, 2023
@matsbryntse matsbryntse changed the title Behavior break on beforeEventEdit event after v5.3.3 Event removed when returning false from beforeEventEdit after v5.3.3 Jul 30, 2023
@matsbryntse matsbryntse self-assigned this Jul 30, 2023
@matsbryntse matsbryntse added the ready for review Issue is fixed, the pull request is being reviewed label Jul 30, 2023
@matsbryntse matsbryntse added this to the 5.5.0 milestone Jul 30, 2023
@SergeyMaltsev SergeyMaltsev modified the milestones: 5.5.0, 5.5.1 Jul 31, 2023
@matsbryntse matsbryntse added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed BLOCKING labels Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working example forum Issues from forum regression Worked previously, now broken resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

3 participants